firehoseio / firehose

Build realtime Ruby web applications. Created by the fine folks at Poll Everywhere.
http://firehose.io/
MIT License
727 stars 72 forks source link

Fix port confusion in documentation & make Rails 3.1 compatible #7

Closed choonkeat closed 12 years ago

choonkeat commented 12 years ago

now u can just add this to application.js

//= require firehose
bradgessler commented 12 years ago

Actually this broke the build. I'm reverting the Rails integration out of here. Could you fix that so that it doesn't break when you run specs for this?

choonkeat commented 12 years ago

Pushed a fix. However, regardless of this piece of code, my rake spec is getting

bash$ rake spec
$HOME/.rvm/rubies/ruby-1.9.3-p0/bin/ruby -S rspec ./spec/integrations/amqp_resources_spec.rb ./spec/integrations/thin_spec.rb ./spec/lib/broker_spec.rb ./spec/lib/consumer_spec.rb ./spec/lib/default_spec.rb ./spec/lib/producer_spec.rb
$HOME/.rvm/gems/ruby-1.9.3-p0@firehose/gems/webmock-1.8.6/lib/webmock/rspec.rb:33:in `<top (required)>': uninitialized constant RSpec::Expectations::ExpectationNotMetError (NameError)
    from $HOME/.rvm/rubies/ruby-1.9.3-p0/lib/ruby/site_ruby/1.9.1/rubygems/custom_require.rb:59:in `require'
    from $HOME/.rvm/rubies/ruby-1.9.3-p0/lib/ruby/site_ruby/1.9.1/rubygems/custom_require.rb:59:in `rescue in require'
    from $HOME/.rvm/rubies/ruby-1.9.3-p0/lib/ruby/site_ruby/1.9.1/rubygems/custom_require.rb:35:in `require'
    from $HOME/test/firehose/spec/spec_helper.rb:14:in `<top (required)>'
    from $HOME/.rvm/rubies/ruby-1.9.3-p0/lib/ruby/site_ruby/1.9.1/rubygems/custom_require.rb:36:in `require'
    from $HOME/.rvm/rubies/ruby-1.9.3-p0/lib/ruby/site_ruby/1.9.1/rubygems/custom_require.rb:36:in `require'
    from $HOME/test/firehose/spec/integrations/amqp_resources_spec.rb:1:in `<top (required)>'
    from $HOME/.rvm/gems/ruby-1.9.3-p0@firehose/gems/rspec-core-2.10.0/lib/rspec/core/configuration.rb:746:in `load'
    from $HOME/.rvm/gems/ruby-1.9.3-p0@firehose/gems/rspec-core-2.10.0/lib/rspec/core/configuration.rb:746:in `block in load_spec_files'
    from $HOME/.rvm/gems/ruby-1.9.3-p0@firehose/gems/rspec-core-2.10.0/lib/rspec/core/configuration.rb:746:in `map'
    from $HOME/.rvm/gems/ruby-1.9.3-p0@firehose/gems/rspec-core-2.10.0/lib/rspec/core/configuration.rb:746:in `load_spec_files'
    from $HOME/.rvm/gems/ruby-1.9.3-p0@firehose/gems/rspec-core-2.10.0/lib/rspec/core/command_line.rb:22:in `run'
    from $HOME/.rvm/gems/ruby-1.9.3-p0@firehose/gems/rspec-core-2.10.0/lib/rspec/core/runner.rb:69:in `run'
    from $HOME/.rvm/gems/ruby-1.9.3-p0@firehose/gems/rspec-core-2.10.0/lib/rspec/core/runner.rb:10:in `block in autorun'
rake aborted!
$HOME/.rvm/rubies/ruby-1.9.3-p0/bin/ruby -S rspec ./spec/integrations/amqp_resources_spec.rb ./spec/integrations/thin_spec.rb ./spec/lib/broker_spec.rb ./spec/lib/consumer_spec.rb ./spec/lib/default_spec.rb ./spec/lib/producer_spec.rb failed

Tasks: TOP => spec
(See full trace by running task with --trace)