search

fireice-uk / xmr-stak-amd

Monero AMD miner
GNU General Public License v3.0
193 stars 114 forks source link

xmr-stak-amd nicehash support #95

Open dewminer opened 7 years ago

dewminer commented 7 years ago

@ https://github.com/fireice-uk/xmr-stak-amd/releases, the nicehash support for xmr-stak-amd is listed, but obviously it is not working because each share is rejected by nicehash pool. please add nicehash support to xmr-stak-amd also

aaronsace commented 7 years ago

Confirmed.

https://github.com/aaronsace/MultiPoolMiner/issues/299

fireice-uk commented 7 years ago

Hi, you are correct. Although my opinion is that is this cuts the available hashes very thin on 6 gpu machines.

dewminer commented 7 years ago

i'm using the genesis mining sgminer fork patched for nicehash on my 6x RX570 rig https://github.com/nicehash/sgminer-gm/releases

the accepted hashrate from nicehash seems to be ok, the number of rejected shares is around 1%. i understand the possible issue running out of nonces described here: https://github.com/fireice-uk/xmr-stak-amd/issues/66 but it never happened with the sgminer-gm on my rig running 24+ hours and doing 4600H/s

so, imho, the nicehash support has to be added. thanks

psychocrypt commented 7 years ago

@dewminer I cant find any lising that nice hash is supported for the amd version.

dewminer commented 7 years ago

@psychocrypt well, i'm just asking to add the functionality. if there is some possible/probable issue, the README.md can draw attention on it https://github.com/fireice-uk/xmr-stak-amd/issues/66 https://github.com/fireice-uk/xmr-stak-nvidia/issues/24

aaronsace commented 7 years ago

If there is a problem with the stratum protocol in the future then NiceHash will fix it. It currently does work so the code from the CPU version should be used in the GPU version. I can't see any reasoning behind not implementing this; especially since you've already done the hard work in the CPU version.

gboelter commented 7 years ago

Any news about Nicehash support in xmr-stak-amd?

fgarpe commented 7 years ago

Please add Nicehash support

psychocrypt commented 7 years ago

will be in the next release. In around one week

petunder commented 7 years ago

@psychocrypt @fireice-uk I'm really looking forward to the new version XMR-STAK-AMD with the Nicehash support. Is there any understanding when it will be released?

psychocrypt commented 7 years ago

We moved the release to the next weekend.

candrews commented 7 years ago

A bit off topic... Is the plan to discontinue xmr-stak-{amd, cpu, nvidia} in favor of xmr-stak? If so, is there a guess as to when that may happen?

zmate1000 commented 6 years ago

@psychocrypt this weekend or the next weeked? Nov x? Thank you in advance! :)

psychocrypt commented 6 years ago

Planed this WE but if we think at any point the miner is not stable enough than we move it one week.

zmate1000 commented 6 years ago

Thank you we are waiting the SW.

petunder commented 6 years ago

@psychocrypt still waiting. Could you send binaries personally? As beta test?

hovermind commented 6 years ago

cast-xmr-vega working with nicehash getting 1900 - 1950 H/s with VEGA 64 . Although 1.5 % goes to developer , better than sgminer's 1850 H/s.

Tried xmr-stak-amd. Same hash rate as cast-xmr-vega, so it would be nice if nicehash support xmr-stak-amd.

dewminer commented 6 years ago

alternatively, you can use this fork compatible with nicehash: https://github.com/xmrig/xmrig-amd

psychocrypt commented 6 years ago

Please try our latest release https://github.com/fireice-uk/xmr-stak we added dull nicehash support there.