fireice-uk / xmr-stak

Free Monero RandomX Miner and unified CryptoNight miner
GNU General Public License v3.0
4.06k stars 1.79k forks source link

Results rejected. New update wont work with my miners but xmrig does? #1346

Closed agentpatience closed 6 years ago

agentpatience commented 6 years ago

There seems to be a problem with latest xmr-stak build. Supportxmr.com and coinfoundry.org hashrates are half of what they are supposed to be. I can only get xmrig working on my miners. xmr-stak stopped working somehow with Monero during the update.

Can someone look into it?

psychocrypt commented 6 years ago

You missed to fill out the issue template. Withou logs and the config files we can not reproduce the issue. Keep in mind that the pool calculated hash eate is not exact and can variate very strong

agentpatience commented 6 years ago

Yea, but if you just build xmr-stak and test on these two pools you will see the errors. Someone else just posted socket error related messages, i get these on supportxmr pool. I have 10 miners not working on xmr-stak but xm-rig works. I am using centos and ubuntu linux, latest git pull, amd 6234, same setup worked before this update.

agentpatience commented 6 years ago

Please provide as much as possible information to reproduce the issue.

Basic information

Issue with the execution

AMD OpenCl issue

NO

  run `clinfo` and add the output here

Stability issue

psychocrypt commented 6 years ago

the reason why I ask is that I have not the time to reproduce all issues. The most issues are wrong configurations. I do not know how expirence a user is therefore it speedup the solution finding process if we get all information from the beginnen. never the less ich will try to reproduce this issue.

psychocrypt commented 6 years ago

How long does it takes until you see rejected shares. Could you please post the log with the rejected shares. Please also press the key r to show the error log. Please post your pools.txt and cpu.txt Do you mining only with cpu? I tried o reproduce the issue but I got only valid shares.

Spudz76 commented 6 years ago

Working perfect on nanopool Are you sure your pool operators are not idiots? :)

agentpatience commented 6 years ago

The problem shows itself aswell supportxmr.com/coinfoundry poolrate is half of what it should be and I cannot get any accepted shares with xmr-stak. I can't even get one decent share in from a fresh build since the update. I talked to oliver and since xmrig is still working well we feel it is xmr stak but I expect others will see the issues, it should be quite evident if you try to mine to coinfoundry or @supportxmr.com from this build. I will fart around with other pools but I spent a lot of time trying to isolate where the problem is already... my girlfriend is pissed now that I have to setup my 10 boxes again LOL. Pah.

psychocrypt commented 6 years ago

@agentpatience As I wrote I need all the logs and configs from above. I can not reproduce the issue.

agentpatience commented 6 years ago

Ok, let me get you more details. Sorry for my drivel Psycho. I understand your concerns on the setup but I have kept everything the same. Standby.

psychocrypt commented 6 years ago

If you keeped everything the same please remove cpu.txt amd.txt and nvidia.txt and try the defaults

Spudz76 commented 6 years ago

I don't see how it can work fine for days on another XMR pool and be 'wrong' (which obviously also forked v7 or it wouldn't be running).

We really need tcpdump/pcap logs to see what is wrong with the interaction, everything else is just a guess.

Perhaps now that the fork is done, the old non-v7 support can drop completely, and it will work properly. It currently still autodetects based on block version / if the pool is goofing with the version it will confuse the auto-version-jumping in 'monero7' mode. The code does not expect reverse time-travel of the version.

agentpatience commented 6 years ago

There is no amd.txt or nvidia.txt I don't use GPU. I deleted cpu.txt and it created a new one. Here is the error output:

Totals (CPU): 1407.9 1461.4 0.0 H/s

Totals (ALL): 1407.9 1461.4 0.0 H/s Highest: 1636.0 H/s

[2018-04-07 15:18:31] : New block detected. [2018-04-07 15:18:34] : Result rejected by the pool. [2018-04-07 15:18:36] : Result rejected by the pool. [2018-04-07 15:18:36] : New block detected. RESULT REPORT Difficulty : 2393 Good results : 0 / 20 (0.0 %) Avg result time : 4.2 sec Pool-side hashes : 0

Top 10 best results found: | 0 | 0 | 1 | 0 | | 2 | 0 | 3 | 0 | | 4 | 0 | 5 | 0 | | 6 | 0 | 7 | 0 | | 8 | 0 | 9 | 0 |

Error details: | Count | Error text | Last seen | | 20 | Low difficulty share | 2018-04-07 15:18:36 | [2018-04-07 15:18:39] : Result rejected by the pool. [2018-04-07 15:18:41] : Result rejected

agentpatience commented 6 years ago

I can give shell access to the box if you need.

agentpatience commented 6 years ago

[root@mine8-poweredge bin]# tail -f pools.txt

"currency" : "cryptonight",

^C [root@mine8-poweredge bin]# cat pools.txt

/*

"pool_list" : [ {"pool_address" : "stratum+tcp://xmr.coinfoundry.org:3032", "wallet_address" : "439kNhyQXs2TZuXp1Z3kH8G8wV78zVwAVBnYYqToZfNgMC6Gsf3e8kMWbwaVe4vUMveKAzAiA4j8xgUi29TpKXpm3yYtsWW.6234miner8", "rig_id" : "", "pool_password" : "x", "use_nicehash" : false, "use_tls" : false, "tls_fingerprint" : "", "pool_weight" : 1 }, ],

/*

"currency" : "cryptonight",

agentpatience commented 6 years ago

[root@mine8-poweredge bin]# cat cpu.txt

/*

"cpu_threads_conf" : [ { "low_power_mode" : true, "no_prefetch" : true, "affine_to_cpu" : 0 }, { "low_power_mode" : false, "no_prefetch" : true, "affine_to_cpu" : 1 }, { "low_power_mode" : false, "no_prefetch" : true, "affine_to_cpu" : 2 }, { "low_power_mode" : false, "no_prefetch" : true, "affine_to_cpu" : 3 }, { "low_power_mode" : false, "no_prefetch" : true, "affine_to_cpu" : 4 }, { "low_power_mode" : false, "no_prefetch" : true, "affine_to_cpu" : 5 }, { "low_power_mode" : true, "no_prefetch" : true, "affine_to_cpu" : 6 }, { "low_power_mode" : false, "no_prefetch" : true, "affine_to_cpu" : 7 }, { "low_power_mode" : false, "no_prefetch" : true, "affine_to_cpu" : 8 }, { "low_power_mode" : false, "no_prefetch" : true, "affine_to_cpu" : 9 }, { "low_power_mode" : false, "no_prefetch" : true, "affine_to_cpu" : 10 }, { "low_power_mode" : false, "no_prefetch" : true, "affine_to_cpu" : 11 }, { "low_power_mode" : true, "no_prefetch" : true, "affine_to_cpu" : 12 }, { "low_power_mode" : false, "no_prefetch" : true, "affine_to_cpu" : 13 }, { "low_power_mode" : false, "no_prefetch" : true, "affine_to_cpu" : 14 }, { "low_power_mode" : false, "no_prefetch" : true, "affine_to_cpu" : 15 }, { "low_power_mode" : false, "no_prefetch" : true, "affine_to_cpu" : 16 }, { "low_power_mode" : false, "no_prefetch" : true, "affine_to_cpu" : 17 }, { "low_power_mode" : true, "no_prefetch" : true, "affine_to_cpu" : 18 }, { "low_power_mode" : false, "no_prefetch" : true, "affine_to_cpu" : 19 }, { "low_power_mode" : false, "no_prefetch" : true, "affine_to_cpu" : 20 }, { "low_power_mode" : false, "no_prefetch" : true, "affine_to_cpu" : 21 }, { "low_power_mode" : false, "no_prefetch" : true, "affine_to_cpu" : 22 }, { "low_power_mode" : false, "no_prefetch" : true, "affine_to_cpu" : 23 }, { "low_power_mode" : true, "no_prefetch" : true, "affine_to_cpu" : 24 }, { "low_power_mode" : false, "no_prefetch" : true, "affine_to_cpu" : 25 }, { "low_power_mode" : false, "no_prefetch" : true, "affine_to_cpu" : 26 }, { "low_power_mode" : false, "no_prefetch" : true, "affine_to_cpu" : 27 }, { "low_power_mode" : false, "no_prefetch" : true, "affine_to_cpu" : 28 }, { "low_power_mode" : false, "no_prefetch" : true, "affine_to_cpu" : 29 }, { "low_power_mode" : true, "no_prefetch" : true, "affine_to_cpu" : 30 }, { "low_power_mode" : false, "no_prefetch" : true, "affine_to_cpu" : 31 }, { "low_power_mode" : false, "no_prefetch" : true, "affine_to_cpu" : 32 }, { "low_power_mode" : false, "no_prefetch" : true, "affine_to_cpu" : 33 }, { "low_power_mode" : false, "no_prefetch" : true, "affine_to_cpu" : 34 }, { "low_power_mode" : false, "no_prefetch" : true, "affine_to_cpu" : 35 }, { "low_power_mode" : true, "no_prefetch" : true, "affine_to_cpu" : 36 }, { "low_power_mode" : false, "no_prefetch" : true, "affine_to_cpu" : 37 }, { "low_power_mode" : false, "no_prefetch" : true, "affine_to_cpu" : 38 }, { "low_power_mode" : false, "no_prefetch" : true, "affine_to_cpu" : 39 }, { "low_power_mode" : false, "no_prefetch" : true, "affine_to_cpu" : 40 }, { "low_power_mode" : false, "no_prefetch" : true, "affine_to_cpu" : 41 }, { "low_power_mode" : true, "no_prefetch" : true, "affine_to_cpu" : 42 }, { "low_power_mode" : false, "no_prefetch" : true, "affine_to_cpu" : 43 }, { "low_power_mode" : false, "no_prefetch" : true, "affine_to_cpu" : 44 }, { "low_power_mode" : false, "no_prefetch" : true, "affine_to_cpu" : 45 }, { "low_power_mode" : false, "no_prefetch" : true, "affine_to_cpu" : 46 }, { "low_power_mode" : false, "no_prefetch" : true, "affine_to_cpu" : 47 },

],

agentpatience commented 6 years ago

XMRIG output on same blade: [root@mine8-poweredge xmrig]# ./xmrig

agentpatience commented 6 years ago

I loose over 350H/S with xmrig but it is working... so I can isolate it to the software/config.

agentpatience commented 6 years ago

What I can't figure out is why you can't reproduce the errors, can you try mining to: stratum+tcp://xmr.coinfoundry.org:3032

This pool worked flawless for me till the software change. I don't mean to sound like an ass. If it is a pool problem I will let Oliver know but as you can see in my logs that xmrig is able to submit good results to this same pool URL.

psychocrypt commented 6 years ago

you must set currency in pools.txt to "currency" : "monero7", You tried to mine the wrong currency. Cryptonight is not longer used by Monero

agentpatience commented 6 years ago

Oh shit. You are right. You might want to add a condition to change this for the user if he is not keen to it. There are probably a whole bunch of miners where this directive never got changed.

 [2018-04-07 16:04:57] : Pool stratum+tcp://xmr.coinfoundry.org:3032 connected. Logging in...
[2018-04-07 16:05:07] : SOCKET ERROR - [stratum+tcp://xmr.coinfoundry.org:3032] CALL error: Timeout while waiting for a reply
[2018-04-07 16:05:36] : Fast-connecting to stratum+tcp://xmr.coinfoundry.org:3032 pool ...
[2018-04-07 16:05:36] : Pool stratum+tcp://xmr.coinfoundry.org:3032 connected. Logging in...
[2018-04-07 16:05:46] : SOCKET ERROR - [stratum+tcp://xmr.coinfoundry.org:3032] CALL error: Timeout while waiting for a reply
[2018-04-07 16:06:16] : Fast-connecting to stratum+tcp://xmr.coinfoundry.org:3032 pool ...
[2018-04-07 16:06:21] : Pool stratum+tcp://xmr.coinfoundry.org:3032 connected. Logging in...
[2018-04-07 16:06:31] : SOCKET ERROR - [stratum+tcp://xmr.coinfoundry.org:3032] CALL error: Timeout while waiting for a reply
[2018-04-07 16:07:00] : Fast-connecting to stratum+tcp://xmr.coinfoundry.org:3032 pool ...
[2018-04-07 16:07:00] : Pool stratum+tcp://xmr.coinfoundry.org:3032 connected. Logging in...
[2018-04-07 16:07:10] : SOCKET ERROR - [stratum+tcp://xmr.coinfoundry.org:3032] CALL error: Timeout while waiting for a reply
[2018-04-07 16:07:40] : Fast-connecting to stratum+tcp://xmr.coinfoundry.org:3032 pool ...
[2018-04-07 16:07:40] : Pool stratum+tcp://xmr.coinfoundry.org:3032 connected. Logging in...
[2018-04-07 16:07:47] : Difficulty changed. Now: 7500.
[2018-04-07 16:07:47] : Pool logged in.
[2018-04-07 16:07:47] : New block detected.
[2018-04-07 16:07:51] : Result accepted by the pool.
[2018-04-07 16:07:51] : Result accepted by the pool.
[2018-04-07 16:07:53] : Result accepted by the pool.
[2018-04-07 16:07:55] : Result accepted by the pool.
[2018-04-07 16:07:59] : Result accepted by the pool.
[2018-04-07 16:08:00] : Result accepted by the pool.
[2018-04-07 16:08:01] : Result accepted by the pool.
[2018-04-07 16:08:13] : Result accepted by the pool.
[2018-04-07 16:08:16] : Result accepted by the pool.
[2018-04-07 16:08:21] : Result accepted by the pool.
-----------------------------------------------------------------
Totals (ALL):      0.0 1334.9    0.0 H/s
Highest:  1418.6 H/s
agentpatience commented 6 years ago

there are still socket errors on startup of the process however it maybe pool related. I will post it to coinfoundrys work bench. Thanks for your understanding and assistance!

psychocrypt commented 6 years ago

@agentpatience We are supporting now a bunch of currencies. If the user like to miner a cryptonight coin he can do it. Do not forget that Monero is not using cryptonight anymore.

btw: This is why I always ask for the configs. 90% of the issues can be solved by locking to it.

Spudz76 commented 6 years ago

https://github.com/fireice-uk/xmr-stak/releases/tag/2.3.0

In the section that says to change to monero7 and things will Just Work

Not sure but usually documentation should be nearly as good as hand-holding? Also if you bother to run through the new install questions from a blank (no .txts) folder it would have walked you through it, too. Not sure how modifying someones config assuming we know their situation, is any better than the other two vectors for people to know when things change... It's the same for the cpu/amd/nvidia.txt files, when format changes you have to allow a blank regen and then convert your original settings over to whatever the new format is...

fireice-uk commented 6 years ago

Not sure but usually documentation should be nearly as good as hand-holding?

The configuration assumes that that the user is not retarded enough to actively work against getting it right (enter cryptonight when asked to name the coin he is going to mine).

agentpatience commented 6 years ago

Tony, the problem with you is you are too logical and thinking from a biased view being a software developer.

 

When you have multiple miners of all different trades, groups, sects and god knows what else its hard to say everyone will run through all the version change docs by FORCE. It is the engineers that need to make something that is a drop in dummy proof way of traversing through hardware and software changes. I am an electronics engineer and I totally respect your stance on this. I respect your patience and your interest in the thread. We learned some important details here, being that if one tried to upgrade xm-stak without consideration to "cryptonight" --> monero7 configuration change that they would no longer be able to mine.

For some reason, xmr-stak was not able to scale without error like xmrig did during the migration. There are lessons here, 1 for me (read the docs) and 1 for the software engineers... make it easier to deploy xmr-stak by not letting old switches run. eg. "cryptonight". > pass a great sounding error message.

 

Thanks for your help.

Sent: Saturday, April 07, 2018 at 4:18 PM From: "Tony Butler" notifications@github.com To: fireice-uk/xmr-stak xmr-stak@noreply.github.com Cc: agentpatience agentpatience@mail.com, Mention mention@noreply.github.com Subject: Re: [fireice-uk/xmr-stak] Results rejected. New update wont work with my miners but xmrig does? (#1346)

https://github.com/fireice-uk/xmr-stak/releases/tag/2.3.0

In the section that says to change to monero7 and things will Just Work

Not sure but usually documentation should be nearly as good? Also if you bother to run through the new install questions from a blank (no .txts) folder it would have walked you through it, too. Not sure how modifying someones config assuming we know their situation, is any better than the other two vectors for people to know when things change... It's the same for the cpu/amd/nvidia.txt files, when format changes you have to allow a blank regen and then convert your original settings over to whatever the new format is...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

 

fireice-uk commented 6 years ago

cryptonight is not an old switch, we added it together with everything else. Tony actively selected an option that doesn't work, and lo and behold, it doesn't work.

I think the major lesson is just no matter how much you try (we decided to do coin names instead of algo names exactly to prevent users from having to think what is the current algo for their coin), you can't fix stupid.

psychocrypt commented 6 years ago

The old switch is 'monero' try to add this in pools.txt and you will see that the miner is exactly doing what you said.

agentpatience commented 6 years ago

You can't fix my stupidity in thinking cryptonight was what i needed to mine instead of monero7. Man, I feel really stupid now! Thanks guys.