fireice-uk / xmr-stak

Free Monero RandomX Miner and unified CryptoNight miner
GNU General Public License v3.0
4.05k stars 1.79k forks source link

xmr-stak cn7 for nicehash #1444

Closed Selta closed 6 years ago

Selta commented 6 years ago

Hopefully this is simple, and I'm just missing something. I've been using xmr-stak (and, previously xmr-stak-cpu) for mining. I primiarly mine with nicehash now, but sometimes mine XMR as well. When mining with nicehash, I tried setting the pools.txt currency with monero7 and aeon7 as tests, trying to mine cryptonight7. However neither work (all results rejected). If I set to just "cryptonight" and connect to the v7 stratum (stratum+tcp://cryptonightv7.use.nicehash.com:3363) it connects and results are accepted, but nicehash shows them as cryptonight, not as cryptonight7.

I tried setting an invalid option in pools.txt then, "cryptonight7" in the currency field, but that of course failed :).

Any thoughts / help appreciated

psychocrypt commented 6 years ago

monero7 is the right currency to use the new forked POW of monero. I will have a look if nicehash is sending the wrong block version to the miner. Today or tomorrow there will be a update of the dev branch to allow a currency to enforce cryptonight_v7.

Selta commented 6 years ago

Thank you for the prompt reply. If I'm understanding correctly - when I see dev branch update, I can update my xmr-stak miner, and then force cryptonight_v7 there. 1) Would that side-step any issue with NH sending wrong block version? 2) If "no" - that sounds like an issue with NiceHash - should I open a support case with them?

psychocrypt commented 6 years ago

1375 will introduce cryptonight_v7 which not depends on the block version.

I need to check the blockversion send by nicehash first before I can say if it is an nh issue.

Selta commented 6 years ago

Thank you. Shall I leave this issue open to track that?

psychocrypt commented 6 years ago

yes please keep it open until I checked whats going on with nh

psychocrypt commented 6 years ago

Your url is wrong: it must be cryptonightv7.usa.nicehash.com:3363 - USA instead of USE the stratum stuff at the beginning is also not needed

psychocrypt commented 6 years ago

Please post you pools.txt

Selta commented 6 years ago

Apologies, I typo'd on the original issue statement for the URL. With this config, it works fine - I can submit shares and everything works:

"pool_list" :
[
        {"pool_address" : "stratum+tcp://cryptonightv7.usa.nicehash.com:3363", "wallet_address" : "3DGcF39RU44AttqNqeG9o76ifZQr4qY8yu", "rig_id" : "", "pool_password" : "WA1:rjsalamon@hotmail.com", "use_nicehash" : true, "use_tls" : false, "tls_fingerprint" : "", "pool_weight" : 1 },
],

"currency" : "cryptonight",

However, I get "result rejected" messages with this config:

"pool_list" :
[
        {"pool_address" : "stratum+tcp://cryptonightv7.usa.nicehash.com:3363", "wallet_address" : "3DGcF39RU44AttqNqeG9o76ifZQr4qY8yu", "rig_id" : "", "pool_password" : "WA1:rjsalamon@hotmail.com", "use_nicehash" : true, "use_tls" : false, "tls_fingerprint" : "", "pool_weight" : 1 },
],

"currency" : "monero7",

I just tested removing changing the URL to just "cryptonightv7.usa.nicehash.com:3363":

[2018-04-17 08:42:14] : Mining coin: monero7
[2018-04-17 08:42:14] : Starting 1x thread, affinity: 0.
[2018-04-17 08:42:14] : hwloc: memory pinned
[2018-04-17 08:42:14] : Starting 1x thread, affinity: 2.
[2018-04-17 08:42:14] : hwloc: memory pinned
_<snipped out long section not needed>_
[2018-04-17 08:42:14] : Starting 1x thread, affinity: 27.
[2018-04-17 08:42:14] : hwloc: memory pinned
[2018-04-17 08:42:14] : Starting 1x thread, affinity: 29.
[2018-04-17 08:42:14] : hwloc: memory pinned
[2018-04-17 08:42:14] : Fast-connecting to cryptonightv7.usa.nicehash.com:3363 pool ...
[2018-04-17 08:42:14] : Pool cryptonightv7.usa.nicehash.com:3363 connected. Logging in...
[2018-04-17 08:42:15] : Difficulty changed. Now: 100001.
[2018-04-17 08:42:15] : Pool logged in.

Waiting on a result now.

Selta commented 6 years ago

Wow. Looks like that worked!

[2018-04-17 08:43:47] : Result accepted by the pool.
[2018-04-17 08:44:00] : New block detected.
[2018-04-17 08:45:31] : Result accepted by the pool.
[2018-04-17 08:45:37] : Result accepted by the pool.
[2018-04-17 08:45:50] : Result accepted by the pool.
[2018-04-17 08:45:51] : New block detected.
[2018-04-17 08:45:52] : New block detected.
[2018-04-17 08:46:08] : New block detected.

I feel kinda dumb about this now. Thank you for your prompt help. It looks like I should be good to go now.