how about migrate tls library from OpenSSL to mbedTLS

fireice-uk / xmr-stak

Free Monero RandomX Miner and unified CryptoNight miner

GNU General Public License v3.0

4.05k stars 1.79k forks source link

how about migrate tls library from OpenSSL to mbedTLS #1500

Open bughandler opened 6 years ago

bughandler commented 6 years ago

Hi there, I'm working on my own branch of xmr-stak, also I already migrated OpenSSL to mbedTLS. the reasons I do this job are:

the size of generated binary is significant smaller than the original one
it's easier to compile xmr-stak against mbedTLS rather than OpenSSL.

so, my question is that acceptable to you ? if you do, I will commit a PR to your repo

thanks for your time

Spudz76 commented 6 years ago

Looks like it supports Win7+ and should compile with the two MSVC used here, 14.0 and 14.11

I sort of like it?

bughandler commented 6 years ago

@Spudz76 I think it support both win7+ and vs2010+. currently I'm working on vs2017. also it looks like working well in tens of thousands computers 😀

psychocrypt commented 6 years ago

@fireice-uk What do you think about mbedTLS

fireice-uk commented 6 years ago

To be frank, given the amount of bugs found in OpenSSL kind of scares me into sticking to it since so many people reviewed it.

Spudz76 commented 6 years ago

I have never heard of an mbedTLS issue that was beyond theoretical. As a client library there isn't much that can occur, either it works or it doesn't. I might not generate CSR and keys and junk with it but for some TLS transport garbage who cares (mostly driven by the pool end of the handshake, anyway - and anyone that can MitM a major pool probably should end up with everyones coins).

Also LEDE (aka OpenWRT) has offered choice of TLS backend and nobody uses OpenSSL due to its bloat. So if non-OpenSSL was any sort of issue everyones router would be broken.