fireice-uk / xmr-stak

Free Monero RandomX Miner and unified CryptoNight miner

GNU General Public License v3.0

4.06k stars 1.79k forks source link

Replace within cryptonight.commons in Line 68 & Line 72 the following: 8 * 32 through 256 and several times len * 8 could be replaced through len << 3 #2069

Open BrandyThern opened 6 years ago

BrandyThern commented 6 years ago

Please provide as much as possible information to reproduce the issue.

Basic information

Type of the CPU.
Type of the GPU (if you try to miner with the GPU).

Compile issues

Which OS do you use?

add **all** commands you used and the **full** compile output here

run `cmake -LA .` in the build folder and add the output here

Issue with the execution

Do you compiled the miner by our own?

run `./xmr-stak --version-long` and add the output here

AMD OpenCl issue

  run `clinfo` and add the output here

Stability issue

Is the CPU or GPU overclocked?
Is the Main memory of the CPU or GPU undervolted?

psychocrypt commented 6 years ago

There is no need for such changes. The compiler do it for you. This was needed in very old times. The compiler knows that this values are constant and can transform it.