fireice-uk / xmr-stak

Free Monero RandomX Miner and unified CryptoNight miner
GNU General Public License v3.0
4.05k stars 1.8k forks source link

RandomX Algo Inclusion? #2441

Open englishcoder opened 5 years ago

englishcoder commented 5 years ago

Is there some consideration to include RandomX in the near future?

https://github.com/tevador/RandomX/blob/master/README.md

psychocrypt commented 5 years ago

yes we like to include randomx. but currently there is not amd implementation available.

nutsnox commented 5 years ago

I would like to see this too (for wownero namely). There is currently a XMRIG implementation but it's somewhat problematic under Linux. Thanks!

psychocrypt commented 5 years ago

What do you mean with problematic? Could you explain the problems for linux.

nutsnox commented 5 years ago

Problematic for me in that my wownero randomwow hashrate under Linux seems to be lower than Windows (I'm still testing this)... I am primarily using dual/quad cpu miners so may be a NUMA issue? Not sure, but I know that xmrig, historically, has never run well on my quad CPU boxes no matter the algo and always ran better with xmr-stak

Edit: The hardware I'm using is 2x Piledriver CPU Opteron 4365EE with 8GB ram.

soupli commented 5 years ago

yes we like to include randomx. but currently there is not amd implementation available.

Will xmr-stak work for amd cpu ?

psychocrypt commented 5 years ago

AMD CPU yes but AMD Gpus maybe not. It depends if the monero team provide a way to bbuild randomx on amd gpus

soupli commented 5 years ago

True.

CUDA miner seems to be currently working. AMD / OpenCL appears on the todo as you can read below

https://www.reddit.com/r/Monero/comments/bmybxn/randomx_status_update/?utm_medium=android_app&utm_source=share

semeion commented 5 years ago

I preffer xmr-stak so much, but i am using xmrig because the randomx/wow protocol.

Please, consider add this protocol to xmr-stak.

Thank you in advance!

fireice-uk commented 5 years ago

We are unlikely to support the wow variant (as I don't think wow is anything more than a scheme to sell Monero testnet coins). We will support Monero. Do keep in mind though that RandomX will decrease GPU mining profits about 400%. You are unlikely to pay the electricity cost.

semeion commented 5 years ago

To get monero, it is easier to mine WOW with a CPU and change per monero, than to mine monero slowly with a CPU.

I think regardless of the purpose of Wownero, having the option of this protocol in xmr-stak is important.

It would be great if xmr-stak had the option of mining RandomX/WOW only with the CPU, since the GPU can be used to mine Monero directly.

The best gain of electricity would be: CPU mining RandomX / WOW (for Monero trading) GPU mining Monero

jagerman commented 5 years ago

Loki is also moving to a RandomX variant ("RandomXL"), with a testnet fork beginning in a few hours, and the mainnet fork happening towards the end of next month. We'd like for people (and yes, mainly CPU users) to be able to continue using xmr-stak; some guidance on what you'd like us to do to make the integration easier would be helpful (particularly with an eye to coexisting peacefully in the same binary with monero's implementation when it arrives).

psychocrypt commented 5 years ago

thanks for the info that loki is changing the pow.

soupli commented 5 years ago

@jagerman thank you. I will step in on the testnet asap

https://loki.network/2019/06/27/lokis-hashing-algorithm-change/

  1. our revised testnet binaries release date (June 28)
  2. if there are no issues it will be enabled on our Hard Fork date on July 24.
psychocrypt commented 5 years ago

what are the changes of randomxl compared to randomx. Is there a guide which point out all changes?

jagerman commented 5 years ago

what are the changes of randomxl compared to randomx. Is there a guide which point out all changes?

RandomX exposes several knobs designed to make it easy to coins to deploy their own variation by changing (within reason) the constants in src/configuration.h: see https://github.com/tevador/RandomX/blob/master/doc/configuration.md

@soupli - there's a Loki testnet (i.e. RandomXL) pool up at https://dev.imaginary.stream

SomethingGettingWrong commented 5 years ago

I would like to point out although I think its unprofitable there are implmentations being made. unsure if its gonna be worth or not. That has yet to be seen. I have no idea where the GPU's will go once Monero forks to it even if they do!

https://github.com/SChernykh/RandomX_OpenCL https://github.com/SChernykh/RandomX_CUDA

With that being Said i hope to see an Xmr-stak version of the CPU only for Loki and Wow and others eventually. Just my thoughts. Its much better to have competition. This would leave one opensource miner with all the fee's Although if hes the only one that creates it then I guess it doesnt matter. I prefer XMRSTAK

ghost commented 5 years ago

@fireice-uk @psychocrypt please don't support RandomWOW, we have a reputation to uphold.

jagerman commented 5 years ago

The approach in https://github.com/xmrig/xmrig/pull/1050 is worth looking at -- it adds a flexible configuration implementation allowing on-the-fly program configuration changes, which seems far more appropriate for mining software than using the RandomX code/forks directly (which use compile-time constants).

Spudz76 commented 5 years ago

All RandomX based algos also require 2080MB of memory, before the scratchpads, on all devices.

So sub-3GB cards or less are screwed anyway (having 992MB left for scratchpad use @ 3GB - so RandomX turns these into sub-1GB cards immediately) even if the algo wasn't designed to be bad for GPUs in the first place.

The AMD/OpenCL implementation may only be worthwhile on Vega7 and even then only because it has more HBM2 bandwidth than it knows what to do with (overpowering the situation / operating more like a CPU).

Also has much to do with those hashrate differences, it's not a CN algo and does things weird (not just the scratchpads, but has a "DAG" type of blob too). This will expose memory management differences between Linux and Windows more than CN does. It also uses dynamic code so one height could be literally different work than the previous height (you can't so much compare over time, as the work being done is random - thus the name)

necro-nemesis commented 5 years ago

xmrig now has mining RandomXL w CPU covered.

psychocrypt commented 5 years ago

we will provide randomX not sure if we also provide randomXL.

soupli commented 5 years ago

xmrig now has mining RandomXL w CPU covered.

https://github.com/xmrig/xmrig/pull/1050#issuecomment-510129480

necro-nemesis commented 5 years ago

we will provide randomX not sure if we also provide randomXL.

So don't look for any development until we near October.

kio3i0j9024vkoenio commented 4 years ago

Quote: So don't look for any development until we near October.

I most certainly hope there is development going on right now or very soon because XMR-Stak for RandomX needs to be BETA/ALPHA tested well before the fork in October.

psychocrypt commented 4 years ago

I did already the first basics. But I like to eait until the randomx specs are final and we have testpools with the final spec.

kio3i0j9024vkoenio commented 4 years ago

Thanks.

I look forward to the testing period.

hokkjoy commented 4 years ago

Hey guys! Does this help?

psychocrypt commented 4 years ago

from a quick view this post does not contains any mining pool on testnet.

hokkjoy commented 4 years ago

There's now a testnet pool at https://rx.minexmr.com.

psychocrypt commented 4 years ago

thanks for the notification

amzinglyrwarded commented 4 years ago

With the new RandomX algo up and running on XMRig, does XMR-Stak have an implementation in place.... OR will Cryptonight continue to work?

psychocrypt commented 4 years ago

yes we have randomx available and will ship ot soon.

amzinglyrwarded commented 4 years ago

Will I have to update XMR-Stak or will it happen on the backend? Also do you have a date in mind? So I don't forget or overlook the update?

On Mon, Nov 4, 2019, 1:15 PM psychocrypt notifications@github.com wrote:

yes we have randomx available and will ship ot soon.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/fireice-uk/xmr-stak/issues/2441?email_source=notifications&email_token=ANT2GYQ733BWPIPYRZWWUFTQSBRFVA5CNFSM4HN6KOLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDAGQOY#issuecomment-549480507, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANT2GYSKGVPDFK7DWGJA3BTQSBRFVANCNFSM4HN6KOLA .

psychocrypt commented 4 years ago

you need to update stak. You can watch for releases on github. github will notify you if you like.

red0bear commented 4 years ago

hello people ! Any update to randomx algo ?

soupli commented 4 years ago

hello people ! Any update to randomx algo ?

Released yesterday: https://github.com/fireice-uk/xmr-stak/releases/tag/1.0.0-rx

psychocrypt commented 4 years ago

sry forget to push it to this thread. thanks for linking the release.

red0bear commented 4 years ago

@psychocrypt , with that you can still mine old format ?

psychocrypt commented 4 years ago

no xmr-stak-rx can only be used for randomx coins. since we removed the dev fee it would be to confusing for the user if we merge both miner.

xmr-stak-rx --help will show you all suggested algorithms

red0bear commented 4 years ago

@psychocrypt , alright. Why didyou remove fee to devs please ? Just curious.