fireice-uk / xmr-stak

Free Monero RandomX Miner and unified CryptoNight miner
GNU General Public License v3.0
4.06k stars 1.79k forks source link

Microsoft Visual Studio 2019 #2450

Open josef2600 opened 5 years ago

josef2600 commented 5 years ago

hello, i cant compile with Microsoft Visual Studio 2019. these are working: cd C:\xmr-stak "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64 "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\Tools\VsMSBuildCmd.bat" mkdir build cd build set CMAKE_PREFIX_PATH=C:\xmrig\hwloc;C:\xmrig\libmicrohttpd;C:\xmrig\openssl ----------up to here------------ this codes didnt work: cmake -G "Visual Studio 16 2019 Win64",host=x64 .. or cmake -G "Visual Studio 15 2017 Win64" -T v141,host=x64 ..

can have any help here ? thanks, best regards.

psychocrypt commented 5 years ago

You must provide the error else we can not help.

lordhugo7880 commented 5 years ago

Did you install CMake from cmake.org ?

lordhugo7880 commented 5 years ago

"Navigate to https://cmake.org/download/ pick Windows win64-x64 Installer and install CMake (After install set: Add CMake to the system PATH for all users)."

https://www.reddit.com/r/XmrStak/wiki/guides/startup

Adding CMake to the sytem PATH is an option in the CMake installer.

josef2600 commented 5 years ago

i was making it with visual 2017 , no problem. but now i have visual 2019 , and it wont compile : " C:\xmr-stak>"C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64


Visual Studio 2019 Developer Command Prompt v16.1.3 Copyright (c) 2019 Microsoft Corporation


[vcvarsall.bat] Environment initialized for: 'x64'

C:\xmr-stak>"C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\Tools\VsMSBuildCmd.bat"


Visual Studio 2019 MSBuild Command Prompt Copyright (c) 2019 Microsoft Corporation


C:\xmr-stak>mkdir build

C:\xmr-stak>cd build

C:\xmr-stak\build>set CMAKE_PREFIX_PATH=C:\xmr-stak\hwloc;C:\xmr-stak\libmicrohttpd;C:\xmr-stak\openssl

C:\xmr-stak\build>cmake -G "Visual Studio 16 2019 Win64" -T v141,host=x64 .. CMake Error: Could not create named generator Visual Studio 16 2019 Win64

Generators

C:\xmr-stak\build> " i do have CMake ,

josef2600 commented 5 years ago

sorry for the delayed answer, the problem was this: i was using this (like the visual 2017) : "cmake -G "Visual Studio 16 2019 Win64" -T v141,host=x64 .." but i had to use this: "cmake -G "Visual Studio 16 2019" -T v141,host=x64 .." it started compiling, but it made errors. it think it is fixed. thank to myself ! and psychocrypt. best regards, josef.

josef2600 commented 5 years ago

my error is " C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v10.0\include\crt/host_config.h(143): fatal error C1189: #error: -- unsupported Microsoft Visual Studio version! Only the versions between 2013 and 2017 (inclusive) are supported! [C:\xm r-stak\build\xmrstak_cuda_backend.vcxproj] " i think, cuda_10.0.130_411.31_win10 is not good enough ! i need newer cuda.

jonnymaserati commented 5 years ago

The compile instructions need to be updated to reflect what is written here for VS2019: https://www.reddit.com/r/XmrStak/wiki/guides/startup https://www.reddit.com/r/XmrStak/wiki/guides/startup

On 21 Jun 2019, at 10:43, josef2600 notifications@github.com wrote:

sorry for the delayed answer, the problem was this: i was using this (like the visual 2017) : "cmake -G "Visual Studio 16 2019 Win64" -T v141,host=x64 .." but i had to use this: "cmake -G "Visual Studio 16 2019" -T v141,host=x64 .." it started compiling, but it made errors. it think it is fixed. thank to myself ! and psychocrypt. best regards, josef.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/fireice-uk/xmr-stak/issues/2450?email_source=notifications&email_token=AJZFGS5AJRGZUJKFZLBYYL3P3SIB3A5CNFSM4HWQLKEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYH3EJA#issuecomment-504345124, or mute the thread https://github.com/notifications/unsubscribe-auth/AJZFGS7ZEIDWNIRB5M3IHVLP3SIB3ANCNFSM4HWQLKEA.

josef2600 commented 5 years ago

i checked, i have to download cuda_10.1.168_425.25_win10 for visual studio 2019. i did it . best regards, josef.

josef2600 commented 5 years ago

if any one got stuck ! here i have written the full instruction : copy all files in one folder (C:\xmr-stak) like before and : " cd C:\xmr-stak "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64 "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\Tools\VsMSBuildCmd.bat" mkdir build cd build set CMAKE_PREFIX_PATH=C:\xmr-stak\hwloc;C:\xmr-stak\libmicrohttpd;C:\xmr-stak\openssl cmake -G "Visual Studio 16 2019" -T v141,host=x64 .. cmake --build . --config Release --target install cd bin\Release copy C:\xmr-stak\openssl\bin* . "