firelzrd / bore-scheduler

BORE (Burst-Oriented Response Enhancer) CPU Scheduler
GNU General Public License v2.0
314 stars 13 forks source link

Fix required for kernel 6.6.44 #44

Closed ghibo closed 2 months ago

ghibo commented 2 months ago

A change in upstream code for kernel 6.6.44, as of this patch:

https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-6.6.y&id=7ca529748b2df93c7c8c5d73e01e1650ebc226e5

requires bore code to align to newer arguments of reweight_task(), otherwise compilation ends up with error:

kernel/sched/fair.c:159:6: error: conflicting types for 'reweight_task'; have 'void(struct task_struct *, int)'
  159 | void reweight_task(struct task_struct *p, int prio);
      |      ^~~~~~~~~~~~~
In file included from kernel/sched/fair.c:59:
kernel/sched/sched.h:2443:13: note: previous declaration of 'reweight_task' with type 'void(struct task_struct *, const struct load_weight *)'
 2443 | extern void reweight_task(struct task_struct *p, const struct load_weight *lw);
      |             ^~~~~~~~~~~~~
firelzrd commented 2 months ago

Thank you for pointing that out. v5.1.8 has been uploaded. Please try it :)

ghibo commented 2 months ago

Thank you for pointing that out. v5.1.8 has been uploaded. Please try it :)

Yes, both stable/5.1.8 and testing/5.1.10 works.

ghibo commented 2 months ago

Thanks. BTW, a fix is required for le9uo patch companion too for 6.6.44, for having it applying smootly.

firelzrd commented 2 months ago

Thanks for the report. 0001-linux6.11-le9uo-1.6.patch should apply fine. I'll rename the patches.

ghibo commented 1 month ago

Thanks for the report. 0001-linux6.11-le9uo-1.6.patch should apply fine. I'll rename the patches.

yes, the patch applies correctly however the compilation fails at kernel/sysctl.c (at least keeping errors on incompatible-pointer-types).

firelzrd commented 1 month ago

Your contribution is much appreciated. I've just updated the le9uo v1.6 patch for Linux 6.6.44. Any request is welcome, but it's off-topic in here, so please consider raising an issue in the le9uo repo from the next time, not here.

Thank you again, for the report.

ghibo commented 1 month ago

Your contribution is much appreciated. I've just updated the le9uo v1.6 patch for Linux 6.6.44. Any request is welcome, but it's off-topic in here, so please consider raising an issue in the le9uo repo from the next time, not here.

Thank you again, for the report.

Yes, indeed the report was not made in the le9uo repo (at least yours) because (I don't know why), but doesn't appear the button "Issues" there.

firelzrd commented 1 month ago

That's another helpful report. I enabled "Issue" feature of the repo. Somehow it wasn't present. Thank you!