firemaples / EverTranslator

Translate text anytime and everywhere, even you are gaming!
https://play.google.com/store/apps/details?id=tw.firemaples.onscreenocr
GNU General Public License v3.0
139 stars 25 forks source link

Suggestions to improve translate area #419

Open uomar8 opened 9 months ago

uomar8 commented 9 months ago

I think choosing translate area should be improved and here are some suggestions

1- Instead of swiping to create translate area it could be done by two clicks one at the beginning and one at the end IMG_20231228_131146

2- draw to create translate area Screenshot_20231228_131709

3- auto create translate area

4- multiple areas and multiple translate pages

firemaples commented 9 months ago

Thank you for the suggestions.

I think 2 is a feasible solution and would not be hard to implement if I create a rectangle area based on the drawing area. Not sure it is easy to crop an irregular shape. 🤔 (I remember the Google Translate app had the same approach, you can also draw a rectangle to translate a scope)

Solution 1 is also good, and it could avoid triggering the back gesture on the edge of the screen.

Solution 3 is also a possible solution, but the result may be worse than selecting a part of the screen to be translated. I would like to have this feature independently.

For solution 4. The selection view was designed to support multiple selection areas, but I don't know how to arrange multiple results on the screen in a better way. 😅

If I implement 1 or 2, I will keep an option for users to choose which they want. And the visual effect for the approach 2 is better than the approach 1.

What do you think?

uomar8 commented 9 months ago

Yes you're right Google Translate app had the same approach

I agree with what you said approach 2 would look nice, we could skip 1 for now

Isn't allowed to use irregular shape image? 😅 I need to know how things done in general. And why it could give worse results

About 4 😅 i have an idea I hope it's possible to swipe outside the window to switch to the nearest area

IMG_20240102_214031

Screenshot_20240102_214258

Screenshot_20240102_214207_com android gallery3d_edit_45202329168622

firemaples commented 9 months ago

About 4 😅 i have an idea I hope it's possible to swipe outside the window to switch to the nearest area

Wow, this idea sounds great! Let me think about this 👍

uomar8 commented 8 months ago

I got another idea it should be less complicated for users

1- It starts with users select multiple areas 1706261835117

2- New button show Project (20240126124710)_edit_397526253157050

3- once it clicked open new sliding menu from the bottom with all the translate instead of multiple floating windows Ghhwhh (20240126125140)

uomar8 commented 8 months ago

About auto create translate area

1- Instead of Area selection view as (Floating view) we will make it into Fullscreen imagview (activity)

2- we will do the same as this tutorial https://c1ctech.com/recognize-text-in-images-with-ml-kit-on-android/amp/

Or if it's possible to use bounding box with Area selection view and user can edit could be a good idea as well

I didn't test it out yet 😅 to make sure the results are good or bad, what do you think?

firemaples commented 8 months ago

I feel I can try to implement them after the selection screen is also refactored to Compose version to check the feasibility and UX. They should be easy to implement with the new state handler. I've done the refactoring on MainBar and ResultView and tested it on my phone for a week, I'll merge the code to master and try to release it to the store with a low publish percentage to check the stability.

Then, I'll start to refactor the language selection window and the selection view, then implement vertical Japanese recognition, and then start looking into/trying to implement the solutions you proposed, thank you! 🙇‍♂️