search

firemaples / EverTranslator

Translate text anytime and everywhere, even you are gaming!
https://play.google.com/store/apps/details?id=tw.firemaples.onscreenocr
GNU General Public License v3.0
131 stars 23 forks source link

There's a problem with vertical japanese text #420

Open uomar8 opened 6 months ago

uomar8 commented 6 months ago

I used this image as test horizontal-and-vertical-writing

Once I tried horizontal text it's perfect Screenshot_20231228_135017_com android gallery3d_edit_610171250828247

Once I tried virtcal text both jp and jp rtl couldn't read it on the correct order Screenshot_20231228_135134 Screenshot_20231228_135058_com android gallery3d_edit_610156373964707

firemaples commented 6 months ago

I have yet to investigate how to support vertical Japanese texts. (by native support from the libraries or calculating the positions in code) But the result from the last screenshot you posted is better than I expected. At least it read vertically, but the ordering is wrong. 🤔

uomar8 commented 5 months ago

I think this could be an easy solution Just rotate the cropped bitmap and it will work fine Screenshot_20240119_103743_com android gallery3d_edit_650912938911613

https://stackoverflow.com/questions/52623765/ml-kit-android-text-recognition-text-orientation

firemaples commented 5 months ago

I think this could be an easy solution Just rotate the cropped bitmap and it will work fine

Wait..., this solution is amazing!!! 🚀 Thank you for the investigation 😍

I'm working on a refactoring task, let me pick this task after the main components work and are stable.