search

firemodels / fds

Fire Dynamics Simulator
https://pages.nist.gov/fds-smv/
Other
625 stars 610 forks source link

Undefined HEAT_OF_REACTION causes case failure #12936

Closed Bravnewor closed 1 month ago

Bravnewor commented 1 month ago

Describe the bug When I was trying to define liquid fuel, I found that not defining HEAT_OF_REACTION passed the check, but caused the program to fail.

To Reproduce Run the attached case. case.txt

Expected behavior Set a default value for HEAT_OF_REACTION for liquid fuels or return an error message

Desktop (please complete the following information):

rmcdermo commented 1 month ago

Thanks for the report. Looks like this has been fixed, as the latest source runs your test without failing, though since the case is not completely set up it does not really do anything so I cannot attest that all is ok (however, I appreciate the minimal test case!). Please try the nightly build on a full case and see if things work for you.

https://github.com/firemodels/test_bundles/releases/tag/FDS_TEST

Bravnewor commented 1 month ago

Sorry, but nightly builds don't seem to work. I used the FDS-6.9.1-211-g997c1d8-nightly version. The failure still happens on my computer. My liquid fuel case is built according to 9.2.6 of the user guide, and the failure is reproduced by simply deleting the "HEAT_OF_REACTION = 837" line

rmcdermo commented 1 month ago

OK, we will take a look.

mcgratta commented 1 month ago

The logic for liquid fuels was flawed. I fixed it, but in the meantime, set a positive value of HoR. The code will now produce an ERROR if you do not.

Bravnewor commented 1 month ago

Thx for your continued maintenance and prompt replies!