firemodels / fds

Fire Dynamics Simulator
https://pages.nist.gov/fds-smv/
Other
625 stars 610 forks source link

Slice interpolation to nodes at mesh intersections #12987

Closed ericvmueller closed 1 month ago

ericvmueller commented 1 month ago

When interpolating velocity from faces to nodes for smokeview, low values appear at mesh interfaces.

If you run the attached example, essentially a wind tunnel with 4 meshes, and load the u-velocity slice you will see the issue. The u-velocity should appear uniform along the plane of the inlet, as it is prescribed.

Looking at the code, it seems like in the FACE_VALUE routine we are picking up zero values from corner ghost cells which brings down the average at the nodes https://github.com/firemodels/fds/blob/af51fceb44c0b9f2cffc9f92791b0f6379189a48/Source/dump.f90#L5980-L5997

image

(run on intel macOS with the latest master)

slice_test.txt

mcgratta commented 1 month ago

Should work now. Give it a try.

ericvmueller commented 1 month ago

Yup, looks better now - thanks!

image