FDS Source: Add TMPI in Jacobian calc; Fix RAMP Issue

firemodels / fds

Fire Dynamics Simulator

https://pages.nist.gov/fds-smv/

Other

648 stars 618 forks source link

FDS Source: Add TMPI in Jacobian calc; Fix RAMP Issue #13040

Closed cxp484 closed 3 months ago

rmcdermo commented 3 months ago

@cxp484 Please have a look at this case on blaze ignition_delay_T1200K_Phi0p6, it is giving a CVODE error. Please check if this is critical or a warning. If it is ok and just a warning we need to mark it as such. Thanks

cxp484 commented 3 months ago

Let me check.

On Fri, Jun 7, 2024 at 6:27 PM Randy McDermott @.***> wrote:

@cxp484 https://github.com/cxp484 Please have a look at this case on blaze ignition_delay_T1200K_Phi0p6, it is giving a CVODE error. Please check if this is critical or a warning. If it is ok and just a warning we need to mark it as such. Thanks

— Reply to this email directly, view it on GitHub https://github.com/firemodels/fds/pull/13040#issuecomment-2155650954, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHF23ERY2CIBO76OFZZQIFTZGIXTTAVCNFSM6AAAAABI7KCDPGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJVGY2TAOJVGQ . You are receiving this because you were mentioned.Message ID: @.***>

cxp484 commented 3 months ago

I just tried after taking latest. The release solver. (Impi_intel_linux) did run successfully without warning in blaze for T1200 and Phi 0.6 . @rmcdermo can you check again if you still see the problem?

rmcdermo commented 3 months ago

OK, I'll double check.

cxp484 commented 3 months ago

@rmcdermo I can see the warning in debug solver. I will change the ramp and submit the changes.

rmcdermo commented 3 months ago

@cxp484 I just tried rerunning the cases on blaze with the latest source using impi_intel_linux. When I tail *.err I see this.

cxp484 commented 3 months ago

Let me run the cases in blaze. I will modify the ramps for the files which gives warning message.

rmcdermo commented 3 months ago

@cxp484 Sorry, with latest, I now get this.