search

firemodels / fds

Fire Dynamics Simulator
https://pages.nist.gov/fds-smv/
Other
625 stars 610 forks source link

add python version of extinction verification plotting #13070

Closed johodges closed 2 weeks ago

johodges commented 2 weeks ago

I wanted to compare the smoothed version of extinction 2 with existing functionality. Converted the matlab script to python as a start.

rmcdermo commented 2 weeks ago

@johodges This script is not working for me. After running both extinction_1 and extinction_2 locally, then copying this script to fds/Utilities/Python/scripts I get these errors. Note that the files exist per the ls of the directory. Any ideas?

Screenshot 2024-06-17 at 12 08 59 PM

johodges commented 2 weeks ago

Sorry about that, I had the check on if the file exists swapped. The updated commit should fix it. Plots should be generated with the same name as the ones from matlab. Slightly larger at ~5kb on my machine than the existing 4kb.

rmcdermo commented 2 weeks ago

Can you also get rid of the div by zero warning? Thanks