search

firemodels / fds

Fire Dynamics Simulator
https://pages.nist.gov/fds-smv/
Other
674 stars 627 forks source link

Set Default parameters for CVODE #13604

Closed cxp484 closed 1 month ago

rmcdermo commented 1 month ago

I'll let @drjfloyd review. To me, it looks like there are a lot of opportunities to remove input parameters that are already defaults. I'm hoping to get the input file to looking something like this:

&COMB ODE_SOLVER='CVODE'/

which would set the detailed chem defaults.

cxp484 commented 1 month ago

Right now the minimum input is: &COMB FINITE_RATE_MIN_TEMP=300, ODE_SOLVER='CVODE'/ I mentioned it in the UserGuide (snapshot attached).

image

cxp484 commented 1 month ago

The default value for FINITE_RATE_MIN_TEMP is -273.15 K. Therefore, I think user must override it to a more reasonable value, unless setting it to 300°C for CVODE is okay (?).

rmcdermo commented 1 month ago

I would do this in READ_COMB.

IF (TRIM(ODE_SOLVER)=='CVODE') THEN
    ! set other defaults
    IF (FINITE_RATE_MIN_TEMP<-237._EB) FINITE_RATE_MIN_TEMP=300._EB
ENDIF
cxp484 commented 1 month ago

I would do this in READ_COMB.

IF (TRIM(ODE_SOLVER)=='CVODE') THEN
    ! set other defaults
    IF (FINITE_RATE_MIN_TEMP<-237._EB) FINITE_RATE_MIN_TEMP=300._EB
ENDIF

Done. :)

rmcdermo commented 1 month ago

OK, then we need to update the PR to change the documentation and minimize inputs in the input files.