search

firemodels / fds

Fire Dynamics Simulator
https://pages.nist.gov/fds-smv/
Other
648 stars 618 forks source link

Extra column (lumped species) showing up in _mass.csv file #1654

Closed gforney closed 9 years ago

gforney commented 9 years ago 
It seems that the changes in r11532 introduced an error in the mass_file output. For
a lumped species case such as Verification/Species/Propane_flame_deposition_all.fds,
the mass_file used to contain 8 columns:

Time, Total, NITROGEN, OXYGEN, CARBON DIOXIDE, WATER VAPOR, PROPANE, SOOT

which includes only primitive species. Now, after r11532, there are 9 columns, including
the background species as a primitive species.

Time, Total, AIR, NITROGEN, OXYGEN, CARBON DIOXIDE, WATER VAPOR, PROPANE, SOOT.

The "AIR" column has zero values, but it should not be there in the list of primitive
species.

Original issue reported on code.google.com by koverholt on 2012-07-24 16:04:36

gforney commented 9 years ago 
OK, I think I understand what's going on. I'll fix it.

Original issue reported on code.google.com by mcgratta on 2012-07-24 18:29:23

gforney commented 9 years ago 
I introduced a bug searching for input lines with BACKGROUND=.TRUE.

Should work now. Check it.

Original issue reported on code.google.com by mcgratta on 2012-07-24 19:09:54

gforney commented 9 years ago 
Verified working. Thanks.

This should also fix the Propane_flame_deposition plot in the Verification Guide when
Firebot builds tonight. I will check this tomorrow.

Original issue reported on code.google.com by koverholt on 2012-07-24 19:37:58