search

firemodels / fds

Fire Dynamics Simulator
https://pages.nist.gov/fds-smv/
Other
667 stars 625 forks source link

typo in UG #1822

Closed gforney closed 7 years ago

gforney commented 9 years ago 
March 11, 2013
FDS Version 6.0
SVN Repository Revision : 15044

Describe details of the issue below:

9.1.6 Species and Species Mass Flux Boundary Conditions
These boundary conditions are MASS_FLUX(:) and MASS_FRACTION(:) If a ....
=>
These boundary conditions are MASS_FLUX(:) and MASS_FRACTION(:). If a ....

Original issue reported on code.google.com by springcb38 on 2013-03-11 14:02:58

gforney commented 9 years ago 
I changed the syntax. It is now

ORIENTATION(1:3,N)

where N is the index of the orientation vector in cases where there are more than one
orientations for a given Lagrangian particle.

Original issue reported on code.google.com by mcgratta on 2013-06-24 12:37:44

gforney commented 9 years ago 
In example of 'surf_mass_vent_nonchar_spher_gas',
&DEVC XYZ = 0.0,0.0,0.0,IOR = 3, 
    QUANTITY = 'SURFACE DENSITY', 
    ID = 'Surface density'
    STATISTICS = 'SURFACE INTEGRAL' 
    XB = -0.5,0.5,-0.5,0.5,0.0,0.0 /

XYZ has no meaning.

Original issue reported on code.google.com by springcb38 on 2013-06-25 11:59:35

gforney commented 9 years ago 
Thanks. I removed the XYZ in these DEVC lines.

Original issue reported on code.google.com by mcgratta on 2013-06-25 14:28:06

gforney commented 9 years ago 
When running the example of 'cable_11_insulation_mcc', 
I encountered the following error statement.

ERROR: DEVC QUANTITY NORMALIZED HEAT RELEASE RATE not found

Original issue reported on code.google.com by springcb38 on 2013-06-26 01:06:24

gforney commented 9 years ago 
Sorry!
I found that quantity in the latest data.f90 file.

Original issue reported on code.google.com by springcb38 on 2013-06-26 02:22:43

gforney commented 9 years ago 
in User's Guide

Table 17.14
&MISC

CONSTANT_SPECIFIC_HEAT | Real    | 
->
CONSTANT_SPECIFIC_HEAT | Logical |

Original issue reported on code.google.com by springcb38 on 2013-09-13 09:27:51

gforney commented 9 years ago 
Thanks. I fixed it.

Original issue reported on code.google.com by mcgratta on 2013-09-13 12:17:05

gforney commented 9 years ago 
in User's Guide

Table 17.26
SPREAD_RATE | | | | 0.
->
SPREAD_RATE | | | | 0.05

Table 17.30
SPREAD_RATE | | | | 0.0
->
SPREAD_RATE | | | | 0.05

Original issue reported on code.google.com by springcb38 on 2013-09-24 00:46:10

gforney commented 9 years ago 
Thanks, I corrected it.

Original issue reported on code.google.com by mcgratta on 2013-09-24 13:38:53

gforney commented 9 years ago 
In User's Guide (FDS Version 6.0.0, SVN: 17354) page 96

&HVAC TYPE='FAN', ID='constant volume', VOLUME_FLOW=10.0/
&HVAC TYPE='FAN', ID='quadratic', MAX_FLOW=10., MAX_PRESSURE=500./
&HVAC TYPE='FAN', ID='user fan curve', RAMP_ID='fan curve'/

Should read (?):

&HVAC TYPE_ID='FAN', ID='constant volume', VOLUME_FLOW=10.0/
&HVAC TYPE_ID='FAN', ID='quadratic', MAX_FLOW=10., MAX_PRESSURE=500./
&HVAC TYPE_ID='FAN', ID='user fan curve', RAMP_ID='fan curve'/

Original issue reported on code.google.com by stefan.ledin@hsl.gsi.gov.uk on 2013-11-20 15:05:21

gforney commented 9 years ago 
yes thanks.

Original issue reported on code.google.com by drjfloyd on 2013-11-20 15:10:22

gforney commented 9 years ago 
In User's Guide (FDS Version 6.0.0, SVN: 17354) page 96

&RAMP ID='fan curve',F=-1000,T= 17.32/
&RAMP ID='fan curve',F= -800,T= 16.12/
&RAMP ID='fan curve',F= -600,T= 14.83/
&RAMP ID='fan curve',F= -400,T= 13.42/
&RAMP ID='fan curve',F= -200,T= 11.83/
&RAMP ID='fan curve',F= 0,T= 10.00/
&RAMP ID='fan curve',F= 200,T= 7.75/
&RAMP ID='fan curve',F= 400,T= 4.47/
&RAMP ID='fan curve',F= 600,T= -4.47/
&RAMP ID='fan curve',F= 800,T= -7.75/
&RAMP ID='fan curve',F= 1000,T=-10.00/

Should read (?):

&RAMP ID = 'fan curve', F =  1000, T = -10.00 /
&RAMP ID = 'fan curve', F =   800, T =  -7.75 /
&RAMP ID = 'fan curve', F =   600, T =  -4.47 /
&RAMP ID = 'fan curve', F =   400, T =   4.47 /
&RAMP ID = 'fan curve', F =   200, T =   7.75 /
&RAMP ID = 'fan curve', F =     0, T =  10.00 /
&RAMP ID = 'fan curve', F =  -200, T =  11.83 /
&RAMP ID = 'fan curve', F =  -400, T =  13.42 /
&RAMP ID = 'fan curve', F =  -600, T =  14.83 /
&RAMP ID = 'fan curve', F =  -800, T =  16.12 /
&RAMP ID = 'fan curve', F = -1000, T =  17.32 /

-------------------

FDS expects T to be given in increasing order

Original issue reported on code.google.com by stefan.ledin@hsl.gsi.gov.uk on 2013-11-20 15:11:25

gforney commented 9 years ago 
yes, thanks.  At some point in developing HVAC I flipped which was T and which was F
for the fan curve and I guess I just switched T and F in the manual without reordering.

Original issue reported on code.google.com by drjfloyd on 2013-11-20 15:18:18

gforney commented 9 years ago 
FDS source code, read.f90
line 5081 :

THICKESS -> THICKNESS

Original issue reported on code.google.com by springcb38 on 2014-03-11 11:31:39

gforney commented 9 years ago 
thanks.

Original issue reported on code.google.com by drjfloyd on 2014-03-11 12:20:53

gforney commented 9 years ago 
FDS source code, read.f90
line 8878 :

N_TRACKED_SPECIES > 0._EB 
  ->
N_TRACKED_SPECIES > 0

Original issue reported on code.google.com by springcb38 on 2014-03-12 11:38:58

gforney commented 9 years ago 
Got it, thanks.

Original issue reported on code.google.com by mcgratta on 2014-03-12 12:22:31

gforney commented 9 years ago 
hvac.f90
509 line : 
.... Airocil ...
->
.... Aircoil ...

Original issue reported on code.google.com by springcb38 on 2014-03-17 01:17:19

gforney commented 9 years ago 
thanks

Original issue reported on code.google.com by drjfloyd on 2014-03-17 14:53:39

gforney commented 9 years ago 
p.134
&REAC ID='R2'
      A = 1.5e9

->
      A = 3.98e8
by Andersen et al.

right?

Original issue reported on code.google.com by springcb38 on 2014-04-01 11:13:27

gforney commented 9 years ago 
(No text was entered with this change)

Original issue reported on code.google.com by mcgratta on 2014-04-01 15:53:03

gforney commented 9 years ago 
p. 27
&REAC FUEL   = 'HEPTANE'
->
&REAC FUEL   = 'N-HEPTANE'

(although it's a section just for input file structure....)

Original issue reported on code.google.com by springcb38 on 2014-04-02 00:47:00

gforney commented 9 years ago 
I changed the fuel name. Better to be consistent and not cause confusion.

Original issue reported on code.google.com by drjfloyd on 2014-04-02 01:48:29

gforney commented 9 years ago 
@springcb38, you are correct that the A from the paper is 3.98e8, but the parameter
used in the example is modified from source. If you look at the NIST RSE and FSE examples,
1.5e9 is used in R2.

Original issue reported on code.google.com by CraigWeinschenk on 2014-04-03 15:23:00

gforney commented 9 years ago 
UG p. 244
MASS_EXTINCTION_COEFFICIENT = 0
-> 
MASS_EXTINCTION_COEFFICIENT = 8700

Original issue reported on code.google.com by springcb38 on 2014-07-09 09:09:15

gforney commented 9 years ago 
hvac.f90 (19676)

366 EFFICIENCY =1.0_EB
373 EFFICIENCY =0.0_EB

?

In USER's GUIDE, EFFICIENCY = 1.0

Original issue reported on code.google.com by springcb38 on 2014-07-24 09:42:50

gforney commented 9 years ago 
Thank you.

Original issue reported on code.google.com by drjfloyd on 2014-07-24 11:57:02

gforney commented 9 years ago 
In FDS+Evac User's Guide,

34page, 
    door widht -> door width

74page, 8.1 The MESH Namelist Group
    NO_EVACUATION is set to .FALSE. -> NO_EVACUATION is set to .TRUE.

78page, 8.6 The HOLE Namelist Group
    for all evacuation mesh obstacles, -> for all evacuation mesh holes,

Original issue reported on code.google.com by springcb38 on 2015-02-10 10:46:23

gforney commented 9 years ago 
INITIAL_VALUE is not a keyword on &CTRL namelist.

FDS User Guide 187page,
15.5.3 Control Function: DEADBAND

INITIAL_VALUE
-> initial value

Original issue reported on code.google.com by springcb38 on 2015-04-21 05:29:01

gforney commented 9 years ago 
User's Guide, 14.4.4

For the cylinder, the area is twice the radius times the length
=>
For the cylinder, the area is 2pi times the radius times the length

Original issue reported on code.google.com by springcb38 on 2015-04-27 04:44:35

gforney commented 9 years ago 
I fixed the typo mentioned in #81.

Original issue reported on code.google.com by mcgratta on 2015-04-27 13:47:18

gforney commented 9 years ago 
Are there any comments in this issue that have not been addressed? If so, start a new
issue. There might be more than one person needed to respond.

Original issue reported on code.google.com by mcgratta on 2015-04-27 13:52:00

gforney commented 9 years ago 
If Project Member make comment, I just thought that all my comments above that had been
resolved.

I did not check whether typo was fixed or not.

Original issue reported on code.google.com by springcb38 on 2015-04-28 02:32:53

gforney commented 9 years ago 
read.f90
subroutine READ_DEVC
           :
      DV%CTRL_ID           = CTRL_ID
      DV%DEVC_ID           = DEVC_ID
      DV%CTRL_ID           = CTRL_ID
           :

"DV%CTRL_ID = CTRL_ID" line is repeated.

Original issue reported on code.google.com by springcb38 on 2015-05-10 06:57:22

gforney commented 9 years ago 
read.f90
subroutine READ_DEVC
            :
       DV%CTRL_ID           = CTRL_ID
       DV%DEVC_ID           = DEVC_ID
       DV%CTRL_ID           = CTRL_ID
            :

"DV%CTRL_ID = CTRL_ID" line is repeated.

I fixed this.

Original issue reported on code.google.com by mcgratta on 2015-05-11 14:07:28

gforney commented 9 years ago 
The procedure of the subroutine call in read.f90 is the same with below.
       :
CALL READ_MESH(1) ; IF (STOP_STATUS==SETUP_STOP) RETURN
CALL READ_EVAC(1) ; IF (STOP_STATUS==SETUP_STOP) RETURN
CALL READ_MESH(2) ; IF (STOP_STATUS==SETUP_STOP) RETURN
CALL READ_TRAN    ; IF (STOP_STATUS==SETUP_STOP) RETURN
CALL READ_TIME    ; IF (STOP_STATUS==SETUP_STOP) RETURN
       :
Then, following is described at subroutine READ_TIME.

IF (.NOT.SYNCHRONIZE) SYNC_TIME_STEP = .FALSE.

This means that .not.SYNCHRONIZE on &TIME forces all SYNCHRONIZE on &MESH to .FALSE.

However, in user guide,

"It is also possible to synchronize the time step in only a select set of meshes. To
do this, add SYNCHRONIZE=.TRUE. to the appropriate MESH lines and then add SYNCHRONIZE=.FALSE.
to the TIME line."

There is inconsistency between source code and user's guide.

Original issue reported on code.google.com by springcb38 on 2015-05-18 12:29:15

gforney commented 9 years ago 
Thanks. We plan to remove the SYNCHRONIZATION option, which will fix this inconsistency.

Original issue reported on code.google.com by mcgratta on 2015-05-28 20:55:00

gforney commented 9 years ago 
default value of SURFACE_TENSION in U.G
7.28e4
->
7.28e-2

Original issue reported on code.google.com by springcb38 on 2015-05-29 11:47:49

gforney commented 9 years ago 
Do you plan to remove the SYNCHRONIZATION option ?
So,
SYNCHRONIZE=.FALSE. is implicitly applied ?

Original issue reported on code.google.com by springcb38 on 2015-05-29 11:50:07

gforney commented 9 years ago 
No, SYNCHRONIZE=.TRUE.; that is, all meshes use the same time step.

Original issue reported on code.google.com by mcgratta on 2015-05-29 12:58:31

gforney commented 9 years ago 
read.f90

TAU_PART= 0._EB
-> 
TAU_PART=1.0_EB (by User's Guide)

Original issue reported on code.google.com by springcb38 on 2015-06-15 02:32:32

gforney commented 9 years ago 
hvac.f90

SUBROUTINE SET_HVAC_DEFAULTS
   : 
COOLANT_TEMPERATURE = 293.15_EB 

->
COOLANT_TEMPERATURE = 0._EB

Original issue reported on code.google.com by springcb38 on 2015-06-15 04:22:11

gforney commented 9 years ago 
->
COOLANT_TEMPERATURE = 20._EB

Original issue reported on code.google.com by springcb38 on 2015-06-15 04:23:31

gforney commented 9 years ago 
fixed coolant temperature.

Original issue reported on code.google.com by drjfloyd on 2015-06-15 13:36:01

gforney commented 9 years ago 
what about #92 ?

Original issue reported on code.google.com by springcb38 on 2015-06-16 00:11:47

gforney commented 9 years ago 
Kevin,

Any reason we have TAU_PART=0 in the source?  Should we change the source or the  guide
for this one?

Jason

Original issue reported on code.google.com by drjfloyd on 2015-06-16 17:48:29

gforney commented 9 years ago 
My guess is that we set it to zero to satisfy some verification case. I would set it
to 1 in the source, just to be consistent with other ramped quantities.

Original issue reported on code.google.com by mcgratta on 2015-06-16 18:29:17

gforney commented 9 years ago 
changed TAU_PART to 1.

Original issue reported on code.google.com by drjfloyd on 2015-06-17 12:20:25

gforney commented 9 years ago 
<source code>
OUTPUT_QUANTITY(161)%NAME = 'ASPIRATION'
OUTPUT_QUANTITY(161)%UNITS = '%/m' 

<User guide>
ASPIRATION Section 15.3.7 %
->
ASPIRATION Section 15.3.7 %/m

Original issue reported on code.google.com by springcb38 on 2015-06-18 01:15:11

gforney commented 9 years ago 
<User guide>
FRICTION VELOCITY Section 16.10.14       B,D
->
FRICTION VELOCITY Section 16.10.14  m/s  B,D

Original issue reported on code.google.com by springcb38 on 2015-06-18 01:25:47