search

firemodels / fds

Fire Dynamics Simulator
https://pages.nist.gov/fds-smv/
Other
625 stars 610 forks source link

TIME_SHRINK_FACTOR in PYROLYSIS #3877

Closed rmcdermo closed 8 years ago

rmcdermo commented 8 years ago

Please have look at Line 2103-2107 in wall.f90. When we get C_S out of EVALUATE_RAMP we apply C_S_ADJUST_UNITS = 1000._EB/TIME_SHRINK_FACTOR.

This is very confusing.

  1. Should we not be applying TIME_SHRINK_FACTOR for case without a ramp?
  2. Why would we apply the unit conversion here only for ramps?
mcgratta commented 8 years ago

Probably so. I'd like to apply TSF in as few places as possible to avoid doubly applying it.

rmcdermo commented 8 years ago

My suggestion is to just remove C_S_ADJUST_UNITS in PYROLYSIS and use it only in read. I think that by the time we get to wall ML%C_S should have the right value and units (which it apparently does have sans ramp). But the ramp logic is opaque here.

mcgratta commented 8 years ago

Done, #3884

mcgratta commented 8 years ago

I'll close this issue after successfully passing a firebot run.