firemodels / smv

Smokeview
Other
45 stars 177 forks source link

Exterior surface shown on removable door #2053

Closed rmcdermo closed 1 month ago

rmcdermo commented 1 month ago

I am not sure what the expected behavior is for this case. So, maybe @drjfloyd or @mcgratta can confirm.

When I run this case (latest smv test bundle):

opening_ulmat.fds.txt

and look at the box from an exterior angle for the door, the door appears to cover the outside. If looking from the interior side, the behavior is as expected. The door is later removed and things look like I would expect (no door from either angle).

Screenshot 2024-10-04 at 9 29 19 AM

Screenshot 2024-10-04 at 9 29 26 AM

rmcdermo commented 1 month ago

I guess the more I think about this, the more I can see maybe this is intended: we show the OBST covering the OPEN boundary, but we do not show the exterior wall. If this is correct, then just close this. Thanks

rmcdermo commented 1 month ago

Well, this gets more interesting with multiple meshes. With the attached input file, the door does not seem to be removed in SMV, though the fluid solver seems to think the zones are now connected (0 and 1 on the left mesh).

opening_ulmat.fds.txt

Screenshot 2024-10-04 at 9 42 37 AM

drjfloyd commented 1 month ago

Smokeview should not show a VENT on an MESH boundary for the domain when that boundary is between the eye and the inside of the domain.

If you run with T_END = 0 to just generate an smv file, Smokeview should show all OBST as CTRL/DEVC logic is not evaluated in that case. If you run with time stepping then Smokeview should show all active OBST.

If the first two images in the first post are before and after an OBST is removed, then that is the expected behavior.

The last two images of side-by-side meshes doesn not look correct.

rmcdermo commented 1 month ago

My last post might have something to do with my code versus the master or intel compiler versus gnu. Let me track that down.

drjfloyd commented 1 month ago

On my PC running a recent smokeview test bundle the door disappears.

gforney commented 1 month ago

I'm working on a couple of issues that may be related https://github.com/firemodels/smv/issues/2046 https://github.com/firemodels/smv/issues/1915 I may have a fix for the 2046 issue. I'm testing with smokebot now. I'll see if it makes a difference for your case in this issue

rmcdermo commented 1 month ago

The door disappears for me too in all cases. Seems my problem was NFS related and the files were not updating as fast as I thought they should.

I do still see the door on the boundary as in the first post. That door is due to an OBST, not just a vent, so I am still not clear on whether this is expected or not.

drjfloyd commented 1 month ago

Active OBST are always displayed.

rmcdermo commented 1 month ago

OK, I think this can be closed. Sorry for the diversion.