Incompatibility with Tectonic / Terralith

[Rebel459]

Not sure which one, assumed it would be Tectonic but I’ve heard of a similar problem with Terralith. Issue on 1.20 Fabric, would greatly appreciate it if compatibility could be looked into.

[firenh]

I will look into it, but unfortunately I believe this is likely an issue on Terralith's end. Profundis works by modifying the vanilla biome distribution, while Terralith and other datapacks like it override the vanilla biome distribution. I have heard some say that using Terrablender helps with it, as Terrablender puts two different biome distributions together. I'm sorry I wasn't super helpful :( I will try to look into it

[Rebel459]

No problem, by the sounds of it there’s not much that can be done anyway. I appreciate the support regardless. Could the issue be bypassed by extracting the data folder of Profundis and using it as a datapack as to avoid it being overridden?

[firenh]

Unfortunately not :/ Profundis works by adding to the VanillaBiomeParameters class (specifically the writeCaveBiomes function) to ensure the most compatibility with other mods. This works because VanillaBiomeParameters is ran during the game to generate the Overworld's biome distribution JSON. However, using a datapack such as Terralith doesn't grant such freedom as they are required to override the Overworld dimension JSON with their own layout, which overrides ALL of the biome layout. The only ways to fix this would be for me to either invasively override how Multinoise works, or to make a new datapack with both Profundis and Terralith biomes, which the latter would be honestly pretty easy to do. Once I push out the new update for Profundis I could try my hand at making a compat layer possibly!

[Rebel459]

That would be amazing if you get the chance, but don’t stress too much! Will keep an eye on this project as I would love to include it in my modpack’s upcoming 1.20 release.

Sent from my iPad

On 21 Jul 2023, at 9:53 am, firenh @.***> wrote:

 Unfortunately not :/ Profundis works by adding to the VanillaBiomeParameters class (specifically the writeCaveBiomes function) to ensure the most compatibility with other mods. This works because VanillaBiomeParameters is ran during the game to generate the Overworld's biome distribution JSON. However, using a datapack such as Terralith doesn't grant such freedom as they are required to override the Overworld dimension JSON with their own layout, which overrides ALL of the biome layout. The only ways to fix this would be for me to either invasively override how Multinoise works, or to make a new datapack with both Profundis and Terralith biomes, which the latter would be honestly pretty easy to do. Once I push out the new update for Profundis I could try my hand at making a compat layer possibly!

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

[Rebel459]

@firenh I think I can add compatibility myself, however I'm not sure what you set these parameters to. If you could provide the parameters, I could probably do it myself and make a compat datapack. Unless I'm missing something, we just need to override this file, but add your biomes to it https://github.com/Stardust-Labs-MC/Terralith/blob/1.20.1/data/minecraft/dimension/overworld.json

[mateus3c]

Terrablender fixes all of those incompatibilities

[Rebel459]

@mateus3c that doesn’t count as a solution, as it absolutely ruins worldgen. Still incompatible, and it’s still an issue. Terrablender does not count towards compatibility imo

[inikishev]

@mateus3c that doesn’t count as a solution, as it absolutely ruins worldgen. Still incompatible, and it’s still an issue. Terrablender does not count towards compatibility imo

wdym by it ruins worldgen. also wdym by Incompatibility with Tectonic / Terralith. whats the issue?

[Rebel459]

@stunlocked1 as most people know, terrablender stuffs biome sizing and weighting, and ruins worldgen. Incompatibility’s pretty clear - biomes are unable to generate

[inikishev]

@stunlocked1 as most people know, terrablender stuffs biome sizing and weighting, and ruins worldgen. Incompatibility’s pretty clear - biomes are unable to generate

it says "Terrablender has nothing to do with biome sizing, that's entirely up to the biome mod dev using it. biome placement noise is a vanilla thing, Terrablender just adds a way to allow multiple biomes to use any given noise parameter:"

[Rebel459]

Please just read what I said previously. It still stands, and I’ve already explained it. It leads to micro-biomes and potential disconnects between worldgen and biomes with some datapacks. Idc what you read, because it doesn’t change the simple reality of what I said

[inikishev]

Please just read what I said previously. It still stands, and I’ve already explained it. It leads to micro-biomes and potential disconnects between worldgen and biomes with some datapacks. Idc what you read, because it doesn’t change the simple reality of what I said

thats just increasing worldgen variety imo. micro-biomes do exist irl. but I see what you are saying

[Rebel459]

Again, due to the nature of Terralith, it breaks worldgen syncing with biomes for some biomes such as the Glacial Chasm or Nullscape’s End biomes. On top of that, there are typically so many micro-biomes together that it ruins it in general, on top of the myriad of issues. Anyway, hopefully some sort of proper compatibility can be sorted at some point, though it’s no big issue if not.