firenh / Profundis

Creative Commons Zero v1.0 Universal
4 stars 4 forks source link

Amethyst Caves biome uses `minecraft:music.overworld.jungle_and_forest` which was removed in 1.20 #19

Open alcatrazEscapee opened 10 months ago

alcatrazEscapee commented 10 months ago

The amethyst caves biome JSON specifies the music sound event as minecraft:music.overworld.jungle_and_forest:

https://github.com/firenh/Profundis/blob/df25f417ee62f0b5d09e9572c5936e7886f14b8e/src/main/resources/data/profundis/worldgen/biome/amethyst_caves.json#L12-L17

However, this does not exist in 1.20. According to a brief search in Linkie, it seems to have existed in 1.19.4 then removed in 1.20:

In 1.19.4:

image

In 1.20 (and onwards):

image

Due to vanilla's poor codec handling, this field being invalid does not error, as the music field is an optional field. When used with [Cyanide](), however, this gets promoted to a full error:

[23:16:10] [Render thread/WARN] (Minecraft) Failed to load level data or datapacks, can't proceed with server load
java.util.concurrent.ExecutionException: java.lang.IllegalStateException: Error(s) loading registries:

Errors(s) loading registry minecraft:worldgen/biome:

Optional field "music" was invalid: Failed to get element ResourceKey[minecraft:sound_event / minecraft:music.overworld.jungle_and_forest]
    at: "effects"
    at: worldgen/biome 'profundis:worldgen/biome/amethyst_caves.json'
    at: pack 'fabric'

Errors occurred freezing registries.
These were elements that were referenced, but never defined (or their definition had an error above).

Missing references from the worldgen/biome registry: [
    'profundis:amethyst_caves'
]

This was reported as an issue to Cyanide here: https://github.com/alcatrazEscapee/cyanide/issues/23