search

firepear / petrel

It's like SQLite, but for networking
MIT License
20 stars 1 forks source link

Pull test coverage back up #21

Closed firepear closed 9 years ago

firepear commented 9 years ago

There is some new code without tests, but I am really tired and want to call 0.16 done. Catch that up in 0.17.

firepear commented 9 years ago

coverage: 92.1% of statements

firepear commented 9 years ago

Added coverage for AddHandler() error cases. 93.7%

firepear commented 9 years ago

Is it possible to get setConnTimeout() to error? Via setting a negative value on a.t maybe? It's an int64, so I can't just pass it a string or anything...

firepear commented 9 years ago

Oh right. No. Because a negative value becomes a positive timeout on a one-shot connection. Pretty sure that's all dead code and setConnTimeout() shouldn't return anything.

Done. 96.7%.

firepear commented 9 years ago

Added coverage for handling of nil commands. 99.2%, which is as good as it gets now.