search

firephp / firephp-core

FirePHP server library for sending PHP variables to the browser.
http://www.firephp.org
224 stars 78 forks source link

file and line number support in options array. #1

Closed hameedullah closed 5 years ago

hameedullah commented 13 years ago

Recently I was using FirePHP in a project where I had to create a kind of wrapper function around firephp. All the error and custom notices were handled by a custom error handler which in turn sent those to FirePHP.

FirePHP was showing line and file number of the custom error handler function, so I forked and added support in the options array so the custom file and line number can be passed.

I am not sure if this will be a useful feature for other people.

cadorn commented 13 years ago

Sorry about not replying earlier. I was not getting notifications from github. I'll look at this later in October.

cadorn commented 11 years ago

If you can add tests around this (default behaviour and with options set) I would be happy to merge this now.

peter279k commented 5 years ago

This PR has the conflicting files and they should be fixed.

cadorn commented 5 years ago

I should get to this soon. The FirePHPCore lib is going to get some tests and then some improvements.

peter279k commented 5 years ago

I should get to this soon. The FirePHPCore lib is going to get some tests and then some improvements.

This PR has the conflicts and it should be fixed before merging this PR.

cadorn commented 5 years ago

This feature seems to have already been added after this PR was opened: https://github.com/firephp/firephp-core/blob/d810b4794531b4ad916e60b213265608991bc406/tests/Features/04-Options.php#L44