search

firephp / firephp-core

FirePHP server library for sending PHP variables to the browser.
http://www.firephp.org
224 stars 78 forks source link

`includeLineNumbers` fails when lib not placed under "FirePHPCore" directory #16

Closed pherrymason closed 10 years ago

pherrymason commented 10 years ago

includeLineNumbers fails to display as the folder name where firephp should be placed is hardcoded in the source. This could be solved by using __DIR__ constant.

I know this is a minor problem as one should use either composer or respect the folder name, but for old projects where I just want to update the lib this was causing a headache trying to figure out why it was not displaying file/numbers.

cadorn commented 10 years ago

I have been meaning to fix this for a while. Feel free to send a PR that includes a check for FILE (don't use DIR as it was introduced later in PHP if I recall correctly).

pherrymason commented 10 years ago

Done