search

firephp / firephp-core

FirePHP server library for sending PHP variables to the browser.
http://www.firephp.org
224 stars 78 forks source link

Exception : 'You must specify a label for the group!' (0 and "0") #18

Closed bkdotcom closed 5 years ago

bkdotcom commented 10 years ago

I just had a script crash and burn on this:

$firephp->group(0);

Exception : 'You must specify a label for the group!'

My suspicions were correct.. the group method is doing an "empty" test:

if (!$Name) {
    throw $this->newException('You must specify a label for the group!');
}

should be if ( is_null($Name) ) or if ( !isset($Name) )

don't be hatin' 0 and "0" ! :)

cadorn commented 10 years ago

If you send PR I can merge this right away.

cadorn commented 7 years ago

Can anyone tell me if this was solved by the PRs? /cc @bkdotcom