search

fireproof-storage / dashboard

1 stars 0 forks source link

dont transform db name #6

Open jchris opened 6 days ago

jchris commented 6 days ago

I think if there is a place we need to be safe with db name characters it shoudnt be here. Principle of least surprise says we should pass through at this layer

https://github.com/fireproof-storage/dashboard/blob/5457a1a9f84b66470487bac54f53581c6688abd5/src/pages/databases/connect.tsx#L14

necrodome commented 5 days ago

I agree but by default indexeddb gateway does this cleaning, https://github.com/fireproof-storage/fireproof/blob/e485c4c2917ab58bb399b0cb549c98bbd2ffaecc/src/runtime/gateways/indexdb/gateway.ts#L64

I just added this to match the current behaviour so we can match it on cloud connect.