Storage engine splitting

fireproof-storage / fireproof

Realtime database, runs anywhere. Install Fireproof in your front-end app or edge function, and sync data via any backend.

https://fireproof.storage

Other

219 stars 16 forks source link

Storage engine splitting #119

Closed valorant-dhruv closed 2 weeks ago

mabels commented 2 weeks ago

Hi, i tried to review this but the title assumes that there should be some "functional" changes but all what i saw it formatting. I recommend that we split formatting PR's from "functional" ones. I know that's hard in the process but to make reviews matter it's somehow needed on my opinion.

Meno

jchris commented 2 weeks ago

Hi, i tried to review this but the title assumes that there should be some "functional" changes but all what i saw it formatting. I recommend that we split formatting PR's from "functional" ones. I know that's hard in the process but to make reviews matter it's somehow needed on my opinion.

Meno

It would be awesome to standardize the vscode env and build chain so we don't have to worry about format shifting

vmx commented 2 weeks ago

It would be awesome to standardize the vscode env

Using some automated formatter, independent of the edior/IDE would be great. Something like dprint or prettier.

jchris commented 2 weeks ago

was able to crash under stress... still investigating before merge