Closed thedanchez closed 5 months ago
There seems to be a lot of issues with the todomvc
example -- my gut is telling me from the looks of it, that example seems pretty out of date with the current state of the @fireproof/core
APIs among other things. Is that a fair characterization of the matter or is there something else I'm missing? cc @jchris
yes the examples need rehab -- there are better examples in other repos. It'd be worth a distinct cleanup effort, probably more along the lines of replacing them or making that folder into links to up to date repos.
I'm merging, and then going to do a commit to switch testing to just the core projects (as it is today) -- once we have test:recursive
passing we can switch back. This will let us tackle that stuff as a distinct change. Thank you!
This PR is a quality of maintainer/contributor life improvement to add top-level scripts that run actions such as:
build
: recursively run allbuild
scripts defined within packagesbuild:clean
: clears alldist
directories from packagesclean
: clears allnode_modules
directories from packagesclean:all
: clears alldist
andnode_modules
from workspacetest
: recursively run alltest
scripts defined within workspace packagesAnd package-scoped versions of the above actions for:
@fireproof/encrypted-blockstore
@fireproof/core
use-fireproof
In doing this effort, many things came up thanks to TypeScript catching problems after renaming some
types.d.ts
files totypes.ts
among other things.This PR also adds a
.nvmrc
file to define the expected Node version for the project (managed by NVM). As a maintainer/contributor, assumingnvm
is installed, all you have to do is executenvm use
and it will set everything up. It is currently set to the latest Node 2010.0 LTS. (NOTE: Node 16 is end of life so we should not be using that anywhere). With Node 18+, thefetch
API is natively built into the runtime, so we should be able to move away from things likecross-fetch
but I felt we could leave that shift to another PR to not further pollute this one.At the very least, having these scripts I think should provide more confidence going forward now that we will be able to see all packages being built and tested successfully alongside potentially adding the success runs of these scripts to GitHub Action workflows.
Remaining TODOs:
examples/todomvc
use-fireproof
React package