search

firescript / nativescript-contacts

A nativescript module that gives access to the native contact directory.
MIT License
28 stars 32 forks source link

Porting to NativeScript 3.0 #24

Closed Dragomir-Ivanov closed 7 years ago

Dragomir-Ivanov commented 7 years ago

Hello there, This useful plugin doesn't work on NativeScript 3.0. I am using getContact(), and it's Promise return doesn't seem to call its callbacks. Any interest in porting the plugin to {N} 3.0?

pascalsalomons commented 7 years ago

Any updates on this issue? I'm having the exact same problem.

Dragomir-Ivanov commented 7 years ago

@pascaloo7 Can you confirm that the plugin works for iOS for you? Maybe I will can to dig deeper on this.

firescript commented 7 years ago

This should be fixed: https://github.com/firescript/nativescript-contacts/blob/master/index.android.js#L17

I confirmed it worked on iOS on a fresh install of Nativescript 3.0 app, Android was broken. There were confirmed breaking changes in the release notes. @Dragomir-Ivanov @pascaloo7

Will update NPM package now.

Thanks @sitefinitysteve and @triniwiz for the help!

Dragomir-Ivanov commented 7 years ago

@firescript Thank you. Works like a charm!