search

firescript / nativescript-contacts

A nativescript module that gives access to the native contact directory.
MIT License
28 stars 32 forks source link

Multiple Accounts Save Contact (Android) #73

Closed comporell closed 3 years ago

comporell commented 4 years ago

Added option to save a contact to a known account on Android. Is it the best way to do this?

fpaaske commented 4 years ago

@firescript, this is a much needed feature, but could we make it even more advanced where we could have an API getAccounts() and extend save() with account Contact.save(account)?

firescript commented 3 years ago

@comporell @fpaaske @dlcole - are we safe to merge this? let me know.

dlcole commented 3 years ago

I’ll test this later this evening.

Sent from my iPhone

On Feb 12, 2021, at 12:23 PM, Ryan Lebel notifications@github.com wrote:

 @comporell @fpaaske @dlcole - are we safe to merge this? let me know.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

comporell commented 3 years ago

@comporell @fpaaske @dlcole - are we safe to merge this? let me know.

nope it is not safe. After having strange issues that break the contact list, I decided to change my logic and implemented https://github.com/rapidwebltd/php-google-contacts-v3-api instead.

firescript commented 3 years ago

@comporell - ok are you planning on fixing the PR? Or should I just close this one up and NOT merge it.

comporell commented 3 years ago

@comporell - ok are you planning on fixing the PR? Or should I just close this one up and NOT merge it.

Hello, please close this and do not merge it. Would be better if someone else tried it from scratch. I had lots of issues with it which eventually lead to lots of lost contacts on a phone with 4 accounts.