search

firescript / nativescript-contacts

A nativescript module that gives access to the native contact directory.
MIT License
28 stars 32 forks source link

Always triggering HMR / Webpack #76

Open andresilva-cc opened 4 years ago

andresilva-cc commented 4 years ago

For some reason, whenever I make a change to my code, some of nativescript-contacts files get triggered by Webpack, which in turn makes HMR do a full restart of the app, instead of just updating the app without a full restart. Check log:

JS: HMR: The following modules were updated:
JS: HMR:          ↻ ../node_modules/nativescript-worker-loader/index.js!../node_modules/nativescript-contacts/get-all-contacts-worker.js
JS: HMR:          ↻ ../node_modules/nativescript-worker-loader/index.js!../node_modules/nativescript-contacts/get-contacts-by-name-worker.js
pdomkar commented 4 years ago

Any news? I have a similar problem, if I have in code: const newContact = new contacts.Contact (); And I make any code change, the app is restarting but change not display in the app. To see the change in the app in the emulator, I have to run the app again.

PetroSuch commented 4 years ago

Are there any solutions to this problem?

gurvancampion commented 4 years ago

Having the same issue, the only way to avoid that is to comment the import in your files when you don't use it while developing and re-add it when building for production.