search

firescript / nativescript-contacts

A nativescript module that gives access to the native contact directory.
MIT License
28 stars 32 forks source link

fix for ViewHierarchy error on iOS #84

Closed dlcole closed 4 years ago

dlcole commented 4 years ago

index.ios.js modified to use presentViewControllerAnimatedCompletion and dismissViewControllerAnimatedCompletion so as to avoid a timing error wherein control was returned before the viewController had been dismissed, thus causing an error if the calling code attempted to display a modal dialog. (issue #75). Also changed frame.topmost()invocation to remove deprecated API warning.

index.android.js modified to correct problem where the activityResult handler was being invoked multiple times, once for each time getContact had been called. Fix is to remove the activityResult listener via appModule.android.off("activityResult", ...) which in turn required putting the activityResult handler into its own function.

firescript commented 4 years ago

Thanks @dlcole - @jzgoda please review as well.

Bidou44 commented 3 years ago

Is it possible that this PR was merged but a new version was not released?