fireshaper / Omnibus

Search for and download comics that are added to GetComics.info easily
Apache License 2.0
181 stars 13 forks source link

Unable to extract Id and Key from the uri #5

Closed theotherp closed 4 years ago

theotherp commented 4 years ago

Thanks for the great tool. I was about to code something similar and then found this by accident.

I get the following error:

See the end of this message for details on invoking 
just-in-time (JIT) debugging instead of this dialog box.

************** Exception Text **************
System.ArgumentException: Invalid uri. Unable to extract Id and Key from the uri https://getcomics.info/run.php-urls/aHR0cHM6Ly9tZWdhLm56LyMhS2dWa2pRS1MhaktFWXprX1hUU1dDX3Z6emhnb0VuTWZSbEFNaGlsakNRR2pqTnZ5enhGMA==
   at CG.Web.MegaApiClient.MegaApiClient.GetPartsFromUri(Uri uri, String& id, Byte[]& iv, Byte[]& metaMac, Byte[]& key)
   at CG.Web.MegaApiClient.MegaApiClient.Download(Uri uri, Nullable`1 cancellationToken)
   at CG.Web.MegaApiClient.MegaApiClient.<>c__DisplayClass73_0.<DownloadFileAsync>b__0()
   at System.Threading.Tasks.Task.InnerInvoke()
   at System.Threading.Tasks.Task.Execute()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Omnibus.Form1.<DownloadComic>d__28.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.<>c.<ThrowAsync>b__6_0(Object state)

I searched for "Something Is Killing the Children" and tried to download issue #1.

Thanks!

fireshaper commented 4 years ago

I have been notified of this issue and at this moment I only have a workaround:

Close Omnibus, open a browser and click on the MEGA button for any comic on getcomics.info Then open Omnibus again and download something that didn't work

I think there's some cookie/session/something being set on the machine that is causing this issue.

theotherp commented 4 years ago

Doesn't work :-(

fireshaper commented 4 years ago

Try the new release https://github.com/fireshaper/Omnibus/releases/tag/1.4.6.2

theotherp commented 4 years ago

Nope, sorry.

fireshaper commented 4 years ago

Can you right-click on the comic you are trying to download and choose "Verify MEGA link" and send me a screenshot of that?

theotherp commented 4 years ago

I only have the option to "Find more like this"...

fireshaper commented 4 years ago

You aren't using the newest release then. I sent you a link direct to it.

On Wed, Jan 15, 2020, 12:11 PM theotherp notifications@github.com wrote:

I only have the option to "Find more like this"...

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/fireshaper/Omnibus/issues/5?email_source=notifications&email_token=ACTJE7IG5SPQCH5H7PVAULDQ547UZA5CNFSM4KGIR6H2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJBCH2I#issuecomment-574759913, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACTJE7ILIH5G4LIMDKNMS53Q547UZANCNFSM4KGIR6HQ .

theotherp commented 4 years ago

Sorry, don't know how that happened

Works with v1.4.6.2. Sorry for the mixup and thanks a lot for the fix!

fireshaper commented 4 years ago

Does the comic download without an error now?

On Wed, Jan 15, 2020, 12:22 PM theotherp notifications@github.com wrote:

Sorry, don't know how that happened

[image: mega link verify] https://user-images.githubusercontent.com/14368889/72455941-ff52fa80-37c3-11ea-99b1-4d56b43f10a9.png .

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/fireshaper/Omnibus/issues/5?email_source=notifications&email_token=ACTJE7IMJGFKONHFWLETIK3Q55A55A5CNFSM4KGIR6H2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJBDMTQ#issuecomment-574764622, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACTJE7IBVICOPD4JNITD5JTQ55A55ANCNFSM4KGIR6HQ .

theotherp commented 4 years ago

See my edit.

fireshaper commented 4 years ago

Great! Glad it works now.