search

fireship-io / fireship.io

Build and ship your app faster https://fireship.io
3.57k stars 1.31k forks source link

Account creation doesn't allow special characters in your password #103

Open markrcummins opened 5 years ago

markrcummins commented 5 years ago

When creating a new account for firebase.io, an error occurs when you add special characters like !@#$% into your password. The code responsible for that is in fireship.io/components/src/app/users/email-login/email-login.component.ts specifically line 30 where the the regex is done: Validators.pattern('^(?=.*[0-9])(?=.*[a-zA-Z])([a-zA-Z0-9]+)$'), It only allows letters and numbers.

sumpton commented 5 years ago

@markrcummins thanks for posting this, because I could not understand why my attempts failed.

Jeff, I suggest you update your "help text" or improve the validator. I was searching for a way to contact you when I bumped into this issue.

Also, I repeatedly tried to login with Google, but it failed as well.

Password must be between 6 and 24 chars and have at least one number