fireship-io / flamethrower

A blazingly fast router for static sites
MIT License
2.78k stars 110 forks source link

Edit mergeHead: remove old node #46

Closed nguyenhuylinhdev closed 2 years ago

nguyenhuylinhdev commented 2 years ago

Fix issue #45

ekwoka commented 2 years ago

This looks like a downgrade to the algorithm. It won't actually handle any nodes out of order.

It doesn't directly handle the bug you found.

The second thing for the scripts I'm not sure I understand the point?

ekwoka commented 2 years ago

Fixed this issue here in line with the old algorithm here: https://github.com/fireship-io/flamethrower/pull/60

nguyenhuylinhdev commented 2 years ago

I think your algorithm #60 is not working correctly, I found a problem with load css order:

Screenshot_1

Screenshot_2

Screenshot_3

ekwoka commented 2 years ago

That does seem like a good case for that!

The original algorithm and spec so far has not included any need for order to be maintained.

So that may be outside the scope of this bugfix.

I'll give some though to how to solve it and either include it in this PR or a new one.

nguyenhuylinhdev commented 2 years ago

Nice! I will close this PR, have a good day!