Closed timsnyder-siv closed 2 years ago
buildroot has already fixed upstream so that it builds cleanly with make 4.3. If we cherry-pick https://github.com/buildroot/buildroot/commit/9e2128bf5072e5f2fd69e2fc0239558782dfc677 it fixes the issue that I hit in firesim CI at https://github.com/firesim/firesim/runs/5773926269?check_suite_focus=true#step:3:58
The quick-fix for this would be to switch back to using firesim/buildroot with only that patch cherry-picked.
This is needed for firesim/firesim#986 to merge. I've temporarily added a cherry-pick of the needed patch into the firesim CI setup scripts so that I can make sure we get through the full CI.
cherry-pick
buildroot has already fixed upstream so that it builds cleanly with make 4.3. If we cherry-pick https://github.com/buildroot/buildroot/commit/9e2128bf5072e5f2fd69e2fc0239558782dfc677 it fixes the issue that I hit in firesim CI at https://github.com/firesim/firesim/runs/5773926269?check_suite_focus=true#step:3:58
The quick-fix for this would be to switch back to using firesim/buildroot with only that patch cherry-picked.