firesim / FireMarshal

Software workload management tool for RISC-V based SoC research. This is the default workload management tool for Chipyard and FireSim.
https://docs.fires.im/en/latest/Advanced-Usage/Workloads/index.html
Other
74 stars 49 forks source link

Need a line break check before merging several Linux configs #273

Open PKUZHOU opened 1 year ago

PKUZHOU commented 1 year ago

Recently I was stucked with an odd problem: after modifying the linux kernel it cannot boot properly due to missing "/init" dir which should have been installed via initramfs.

After inspection, I found the root cause is that, I didn't write a line break in my modified linux config , say firechip/base-workloads/br-base/linux-config: image

Therefore, after marshal merges this config with initramfs.kfrag, two configs are put into one line, resulting in a failure.

image

image

I think we would better have some lines of code to do a line break check before running the config merging. Otherwise some new users may also meet the same problems occationally.