Closed mkeiser82 closed 9 months ago
We also need to update .eslintrc.json
for Vue3.
- "extends": ["firespring/javascript/vue", "plugin:vue/recommended"],
+ "extends": ["firespring/javascript/vue", "plugin:vue/vue3-recommended"],
Then npm run lint:fix
will fix most of the issues.
The remaining lint errors need manually addressed. The deprecation errors can be split to a separate story if we want, but I think the others should be straightforward.
Some things were missed in the modelValue
changes.
Do a find for this.value
, vue.value
and emit('input'
I am not sure it is causing any issues, but do we need to do anything about the bundle.js:110460 The <CKEditor> component requires using CKEditor 5 in version 37 or higher.
warnings?
@cjasonbush approved. I can't click approve since I opened the PR for you.
@mkeiser82 I believe I have all of the items requested fixed. I know you won't be able to check it off, since you created the PR, but it should be ready for you to take another look.