firesprite / memcached-session-manager

Automatically exported from code.google.com/p/memcached-session-manager
0 stars 0 forks source link

I do not think MemcachedBackupSessionManager.generateSessionId() need to be synchronized. #229

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
I have reviewed the code, and as title. Do you agree?

Original issue reported on code.google.com by qian...@gmail.com on 21 Jul 2015 at 1:41

GoogleCodeExporter commented 9 years ago
Yes, AFAICS you're right. Probably at the time I wrote this some tomcat session 
manager I used for inspiration had this synchronized so that I just "copied" it.

Original comment by martin.grotzke on 21 Jul 2015 at 8:07

GoogleCodeExporter commented 9 years ago
So, it could be faster a bit now.:)

Original comment by qian...@gmail.com on 21 Jul 2015 at 10:37

GoogleCodeExporter commented 9 years ago
Thanks, I pushed the change to master.

Original comment by martin.grotzke on 21 Jul 2015 at 9:43