Make sure we use BINARY_FILE as field for geom terrains.

[marcosvanella]

Ciao Ema, can we check that in qgis2fds we are using BINARY_FILE="CHIDXX.bingeom" (where CHIDXX.bingeom is the name of the binary terrain) instead of READ_BINARY=T (deprecated) in the &GEOM line?

Also I noted in a case sent here:

https://github.com/firemodels/fds/issues/10354

that the terrain has a larger number of SURF_IDs than what is pointed to in the triangles indexes (4th column of FACES). Out of caution FDS throws an error where things don't match (i.e. largest index in FACES 4th column vs the list in SURF_ID).

Thanks!

[emanuelegissi]

Sure Marcos. I am going to fix that in the next days.

Il mer 12 apr 2023, 19:41 marcosvanella @.***> ha scritto:

Ciao Ema, can we check that in qgis2fds we are using BINARY_FILE="CHIDXX.bingeom" (where CHIDXX.bingeom is the name of the binary terrain) instead of READ_BINARY=T (deprecated) in the &GEOM line?

Also I noted in a case sent here:

firemodels/fds#10354 https://github.com/firemodels/fds/issues/10354

that the terrain has a larger number of SURF_IDs than what is pointed to in the triangles indexes (4th column of FACES). Out of caution FDS throws an error where things don't match (i.e. largest index in FACES 4th column vs the list in SURF_ID).

Thanks!

— Reply to this email directly, view it on GitHub https://github.com/firetools/qgis2fds/issues/44, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACXMVY3TDEI4UTK4HHFFNILXA3SNRANCNFSM6AAAAAAW374S5U . You are receiving this because you are subscribed to this thread.Message ID: @.***>

[emanuelegissi]

Not yet done, I have 10 very busy days...

[emanuelegissi]

Ciao Marcos, I double checked. Both BlenderFDS and qgis2fds output this kind of GEOMs: &GEOM ID='Example' SURF_ID='NA','A01' BINARY_FILE='Example.bingeom' /

&GEOM ID='Example terrain' SURF_ID='NA','A01' BINARY_FILE='Example terrain.bingeom' / IS_TERRAIN=T EXTEND_TERRAIN=F /

Is it ok? Ema

Il giorno gio 13 apr 2023 alle ore 06:06 Emanuele Gissi < @.***> ha scritto:

Sure Marcos. I am going to fix that in the next days.

Il mer 12 apr 2023, 19:41 marcosvanella @.***> ha scritto:

Ciao Ema, can we check that in qgis2fds we are using BINARY_FILE="CHIDXX.bingeom" (where CHIDXX.bingeom is the name of the binary terrain) instead of READ_BINARY=T (deprecated) in the &GEOM line?

Also I noted in a case sent here:

firemodels/fds#10354 https://github.com/firemodels/fds/issues/10354

that the terrain has a larger number of SURF_IDs than what is pointed to in the triangles indexes (4th column of FACES). Out of caution FDS throws an error where things don't match (i.e. largest index in FACES 4th column vs the list in SURF_ID).

Thanks!

— Reply to this email directly, view it on GitHub https://github.com/firetools/qgis2fds/issues/44, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACXMVY3TDEI4UTK4HHFFNILXA3SNRANCNFSM6AAAAAAW374S5U . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- "When old people used to wish each other peace, we didn't understand the meaning of this word. Now we really understand." [Natalia Balasynovych, mayor of Vasilkiv, Ukraine 2022]

[marcosvanella]

Ema, looks good. So in SURF_ID we only list the names that are getting pointed to in the binary FACES? About IS_TERRAIN=T and EXTEND_TERRAIN=F, I assume you are defining the GEOM_TYPE as number 2 (for terrains). If that is so in blender you don't need these when you write the binary geometry (redundant, FDS sets IS_TERRAIN=T after reading the GEOM_TYPE and EXTEND_TERRAIN=F is the default).

---

From: Emanuele Gissi @.> Sent: Thursday, May 4, 2023 04:24 AM To: firetools/qgis2fds @.> Cc: marcosvanella @.>; Author @.> Subject: Re: [firetools/qgis2fds] Make sure we use BINARY_FILE as field for geom terrains. (Issue #44)

Ciao Marcos, I double checked. Both BlenderFDS and qgis2fds output this kind of GEOMs: &GEOM ID='Example' SURF_ID='NA','A01' BINARY_FILE='Example.bingeom' /

&GEOM ID='Example terrain' SURF_ID='NA','A01' BINARY_FILE='Example terrain.bingeom' / IS_TERRAIN=T EXTEND_TERRAIN=F /

Is it ok? Ema

Il giorno gio 13 apr 2023 alle ore 06:06 Emanuele Gissi < @.***> ha scritto:

Sure Marcos. I am going to fix that in the next days.

Il mer 12 apr 2023, 19:41 marcosvanella @.***> ha scritto:

Ciao Ema, can we check that in qgis2fds we are using BINARY_FILE="CHIDXX.bingeom" (where CHIDXX.bingeom is the name of the binary terrain) instead of READ_BINARY=T (deprecated) in the &GEOM line?

Also I noted in a case sent here:

firemodels/fds#10354 https://github.com/firemodels/fds/issues/10354

that the terrain has a larger number of SURF_IDs than what is pointed to in the triangles indexes (4th column of FACES). Out of caution FDS throws an error where things don't match (i.e. largest index in FACES 4th column vs the list in SURF_ID).

Thanks!

— Reply to this email directly, view it on GitHub https://github.com/firetools/qgis2fds/issues/44, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACXMVY3TDEI4UTK4HHFFNILXA3SNRANCNFSM6AAAAAAW374S5U . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- "When old people used to wish each other peace, we didn't understand the meaning of this word. Now we really understand." [Natalia Balasynovych, mayor of Vasilkiv, Ukraine 2022]

— Reply to this email directly, view it on GitHubhttps://github.com/firetools/qgis2fds/issues/44#issuecomment-1534284127, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABY23VLID2P43U3PVBLUZ6TXENRVRANCNFSM6AAAAAAW374S5U. You are receiving this because you authored the thread.Message ID: @.***>

[emanuelegissi]

This is not fixed yet. We include all the SURF_ID, even unused ones. I need to slightly refactor the code.

[emanuelegissi]

Done