search

firetools / qgis2fds

An open source and free tool to export terrain elevation, landuse, and georeferencing to NIST FDS for computational fluid dynamics (CFD) wildfire or atmospheric pollutants dispersion simulations.
GNU General Public License v3.0
17 stars 13 forks source link

MULT DX, DY, DZ values do not match MESH XB values. #91

Open marcosvanella opened 1 month ago

marcosvanella commented 1 month ago

Ciao Ema, this is from an issue in fds #13479 (https://github.com/firemodels/fds/issues/13479) . The FDS mesh written for the case in the issue is:


&MULT ID='Meshes'
      DX=346.59 I_LOWER=0 I_UPPER=4
      DY=278.26 J_LOWER=0 J_UPPER=7 /
&MESH IJK=34,27,33 MULT_ID='Meshes'
      XB=-866.59,-520.01,-1113.01,-834.76,211.57,543.35 /

The values of DX and DY do not match exactly the XMAX-XMIN, YMAX-YMIN being written (they differ by the last digit). Turns out this difference make distance among meshes to increase as you set more meshes in X,Y. This is leading to issues matching meshes. Can we make sure these numbers match when written? Thanks! M

ericvmueller commented 1 month ago

Is this the same as here https://github.com/firetools/qgis2fds/issues/57? Did that fix ever make it into the main branch? Edit: Ah yeah I see it did, but maybe it is the number of digits in the rounding?

johodges commented 1 month ago

My understanding is the main branch is still behind the dev branch. That fix is in place on dev but the user may be using main.

emanuelegissi commented 1 month ago

Yes, the last release is behind the dev branch, this is why the fix didn't get to the users. I will sync that asap.

3dfirelab commented 1 month ago

I was using version 1.0.2 from the qgisinstallation plugin. So no need to share with you my qgis project?

emanuelegissi commented 1 month ago

No need to share the project. The issue is known and fixed in the dev version. I shall only release a newer version.