search

firetreedesign / ccbpress-core

Introducing the easiest way to display information from Church Community Builder (CCB) on your church WordPress site.
https://churchdataconnect.com/
GNU General Public License v2.0
2 stars 0 forks source link

Pass `item_id` to the updater instead of `item_name` #65

Closed danielmilner closed 4 years ago

danielmilner commented 4 years ago

https://github.com/firetreedesign/ccbpress-core/blob/eff81412254f34e7cd5efee4119cdd0ac1b87920/includes/class-ccbpress-licenses.php#L101-L121

We need to change the names of the add-ons to be more descriptive, but doing so will break the update and license checking. To fix this, we need to switch to using the item_id instead of the item_name. item_id should be a number, but we are currently using it incorrectly as text. If we use is_numeric() to check that the item_id is a number, we can use it, otherwise, fall back to the way it is currently being done.

This will give us some time to update the add-ons and for people to install the updates.

danielmilner commented 4 years ago

Fixed with a7e1166139fa6864ad84c535f0f1733e64446cf9