search

fireundubh / WryeBashTagGenerator

xEdit script for generating tags for Wrye Bash
Mozilla Public License 2.0
21 stars 4 forks source link

Bad tags not removed when suggested tags is empty #4

Open SteveTownsend opened 2 years ago

SteveTownsend commented 2 years ago

If I make this change at l.211 then the bad tags are replaced with a blank Bash section

  //if slSuggestedTags.Count > 0 then
  if True then

Output

[00:00] Start: Applying script "WryeBashTagGenerator"
[INFO] --------------------------------------------------------------------------------
[INFO] WryeBashTagGenerator v1.6.4.7 by fireundubh <fireundubh@gmail.com>
[INFO] --------------------------------------------------------------------------------
[INFO] Using game mode: Skyrim Special Edition

[INFO] Processing... Please wait. This could take a while.
[INFO] --------------------------------------------------------------------------------
[INFO] SeranaDialogAddon.esp
[INFO] -------------------------------------------------------------------------- TESTS
[INFO] ------------------------------------------------------------------------ RESULTS
[INFO] No deprecated tags found.
[INFO] 2 bad tags removed:
       {{BASH:Keywords,Names}}
[INFO] No tags added.
[00:01] Script terminated itself, Result=1

And SNAM reads

An improvement to Serana's dialogue and functionalities as an NPC, making her feel more immersive and organic within the world of Skyrim. Version: 2.6

Support the project on Patreon! https://www.patreon.com/martimius

{{BASH:}}
SteveTownsend commented 2 years ago

fwiw there are a couple of syntax errors in the script I picked up too. I am not waiting for the things I've raised to be fixed, I wound up just picking up some of the new tags you added into a private edit I use. Thanks for those updates.

fireundubh commented 2 years ago
  1. If there were any syntax errors in the script, the script wouldn't run.
  2. I don't see why you'd make that change. Why would you want an empty {{BASH:}}?