fireundubh / WryeBashTagGenerator

xEdit script for generating tags for Wrye Bash
Mozilla Public License 2.0
21 stars 4 forks source link

Invent Tag not being Changed for FNV #5

Open Saizetsu opened 2 years ago

Saizetsu commented 2 years ago

Currently testing on OWB.esm ((BASH:Invent, Names, Relev, Sound, Stats)) on the header, v1.6.4.7 outputs no suggested tags for this plugin.

Though on a side note, after 1.6.4.7 I seem to be unable to get it to add tags to a majority of mods that have suggested tags when running through LOOT, currently on MO2 v2.4.2

Saizetsu commented 2 years ago

The YUP patch plugin is one such example of it removing most of the tags and not adding them back, along with the ADAM mod as well.

FelesNoctis commented 2 years ago

Though on a side note, after 1.6.4.7 I seem to be unable to get it to add tags to a majority of mods that have suggested tags when running through LOOT, currently on MO2 v2.4.2

I've been wondering about this myself. I haven't had 1.6.4.7 recommend tags to me for anything yet, including mods that have had confirmed BASH tags for years and have been removed specifically to test this. Not just in FNV either, but in any game. I'm not sure if I'm doing something wrong or what.

fireundubh commented 2 years ago

@Saizetsu

The YUP patch plugin is one such example of it removing most of the tags and not adding them back, along with the ADAM mod as well.

YUP doesn't have any tags by default.

[INFO] --------------------------------------------------------------------------------
[INFO] YUP - Base Game + All DLC.esm
[INFO] -------------------------------------------------------------------------- TESTS
[INFO] {R.Eyes} (ElementCount) [RACE:00003B3E] \ ENAM - Eyes
[INFO] {R.Hair} (ElementCount) [RACE:00003B3E] \ HNAM - Hairs
[INFO] {R.Head} (CompareKeys) [RACE:000042BE] \ Head Data \ Female Head Data \ Parts \ Part
[INFO] {Deflst} (ElementCountRemove) [FLST:0001515B] \ FormIDs
[INFO] {Invent.Change} (CompareKeys) [CONT:0006747D] \ Items
[INFO] {Invent.Remove} (ElementCountRemove) [CONT:00069EE9] \ Items
[INFO] {Invent.Add} (ElementCountAdd) [CONT:000E3412] \ Items
[INFO] {C.Owner} (Assigned) [CELL:000ECDE8] \ Ownership
[INFO] {C.Encounter} (Assigned) [CELL:001385C4] \ XEZN - Encounter Zone
[INFO] {C.Acoustic} (Assigned) [CELL:00149D78] \ XCAS - Acoustic Space
[INFO] {Relations.Add} (ElementCountAdd) [FACT:00173507] \ Relations
[INFO] {Relations.Change} (CompareKeys) [FACT:00173507] \ Relations
[INFO] ------------------------------------------------------------------------ RESULTS
[INFO] No deprecated tags found.
[INFO] No existing tags found.
[INFO] No bad tags found.
[INFO] 12 suggested tags to add:
       {{BASH:C.Acoustic,C.Encounter,C.Owner,Deflst,Invent.Add,Invent.Change,Invent.Remove,R.Eyes,R.Hair,R.Head,Relations.Add,Relations.Change}}
[INFO] 12 suggested tags overall:
       {{BASH:C.Acoustic,C.Encounter,C.Owner,Deflst,Invent.Add,Invent.Change,Invent.Remove,R.Eyes,R.Hair,R.Head,Relations.Add,Relations.Change}}

Selecting "write suggested tags to header" works, too.

2021-12-04 15_53_49

@FelesNoctis

Not just in FNV either, but in any game. I'm not sure if I'm doing something wrong or what.

Possibility: Only the last loaded plugin is processed - regardless of which plugin you have selected when you run the script.

mods that have had confirmed BASH tags for years

Many mods have tags they don't need. Many people also added unnecessary tags suggested by the script while they had other plugins loaded, hence the aforementioned restriction.

Saizetsu commented 2 years ago

unfortunately I load just the one mod with whatever dependents it needs and this result happens for many other mods, things such as the UOP(TES4) has no suggested tags nor does it fix deprecated tags. I'm not sure why its working for you, like that but for me it doesn't wish to place tags or fix any that it did at one time.