search

firezone / firezone

WireGuard®-based zero-trust access platform with OIDC auth, identity sync, and NAT traversal.
https://www.firezone.dev
Apache License 2.0
6.39k stars 270 forks source link

fix(phoenix-channel): reset heartbeat interval on reconnect #5534

Closed thomaseizinger closed 3 days ago

thomaseizinger commented 4 days ago

Currently, the heartbeat interval of PhoenixChannel keeps running across re-connects. Whilst not necessarily harmful, it is better to reset it together with reconnecting to the websocket to ensure it is aligned to 30s intervals after we connected.

vercel[bot] commented 4 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **firezone** | ⬜️ Ignored ([Inspect](https://vercel.com/firezone/firezone/6qSxS9Phb8t2sp1mVpJuoBAw3j8F)) | | | Jun 25, 2024 4:30am |
github-actions[bot] commented 4 days ago

Terraform Cloud Plan Output

Plan: 15 to add, 23 to change, 2 to destroy.

Terraform Cloud Plan

github-actions[bot] commented 4 days ago

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 233.7 MiB (+1%) 235.4 MiB (+1%) 329 (+43%)
direct-tcp-server2client 239.2 MiB (-1%) 240.7 MiB (-1%) 165 (-21%)
relayed-tcp-client2server 239.3 MiB (+0%) 240.4 MiB (+0%) 276 (-27%)
relayed-tcp-server2client 237.9 MiB (-1%) 238.6 MiB (-1%) 856 (-3%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 500.0 MiB (+0%) 0.06ms (-62%) 42.54% (-0%)
direct-udp-server2client 500.0 MiB (-0%) 0.02ms (+135%) 25.14% (+4%)
relayed-udp-client2server 499.7 MiB (-0%) 0.03ms (-62%) 54.35% (-3%)
relayed-udp-server2client 499.9 MiB (-0%) 0.04ms (+52%) 34.76% (-4%)