firezone / probe

Probe for WireGuard® connectivity
https://probe.sh
Apache License 2.0
16 stars 1 forks source link

feat: PoC #3

Closed jamilbk closed 4 months ago

jamilbk commented 4 months ago

Almost a first working version. Needs a few more things wired up but I thought I would get a review on it so far.

Notable things that may differ from how I see the backend is implemented:

jamilbk commented 4 months ago

Oh also, I bought a new domain: probe.sh.

I figured it might be wise to run this from another domain just in case.

jamilbk commented 4 months ago

@AndrewDryga I pushed some more updates. It might be good to sync up on a call on a few things I thought about as I was working on this over the weekend.

As you can see by the quite hacky code quality, I'm biasing towards getting this shipped ASAP. If it's going to be a flop, I'd hate to sink too much time into it.

AndrewDryga commented 4 months ago

Do we need the advanced checks + server responses? I was thinking we could just check that each message type makes it from client -> server and call it a day. Most DPI won't take packet "direction" into account (checking the src and dst fields), and most don't carry much, if any packet state (i.e. sequences) because that eats a lot of RAM. Most will simply drop the handshake initiation.

The reason I'm including that is because they can target headers of response packets, without holding the state of the connection. If you think we can skip that - I'm ok with that.

AndrewDryga commented 4 months ago

I'm merging, we can fix stuff along the way, no need to do a full review here.