search

firmata / firmata.js

JavaScript implementation of the Firmata protocol
711 stars 147 forks source link

Test Upgrade to Serialport 4x #128

Closed reconbot closed 8 years ago

reconbot commented 8 years ago

To be used in testing. By the 4.0.0 release I hope to have browser serialport in parity.

SerialPort 4.0.0-rc1 is out and brings performance improvements, bug fixes and a few changes to the api. It's now out of sync with browser-serialport but not in a major way. https://github.com/garrows/browser-serialport/issues/40

I suspect this upgrade won't have any far reaching unattended effects as firmata uses only a fraction of the functions of SerialPort by default. The coms changes will be cleaner when browser serial port catches up.

reconbot commented 8 years ago

Tests are still not in great shape, they're written to the previous API

rwaldron commented 8 years ago

I resolved this and landed a variant of the upgrade

rwaldron commented 8 years ago

https://github.com/firmata/firmata.js/commit/dd07058faade035081ade988cd8889771580ada8