search

firoorg / firo-client

MIT License
19 stars 13 forks source link

Swap from XRP to Firo -> NO Destination Tag #179

Open sirrok opened 2 years ago

sirrok commented 2 years ago

In the case of a swap within the Firo client, no destination tag is generated or displayed when swapping to Firo. This means that in the worst case the sent coins are lost on a swap exchange. I noticed this soon enough with a SWAP from XRP to Firo. And have not carried out the SWAP. I started the swap at "ChangeNow" and "StealthEx" both show no "Destination Tag". Can anyone here confirm that it also works "without" destination tag ?

Greetings Sir Rok

davincci9412 commented 2 years ago

Hi sirrok, this is Vong who integrated APIs to Firo client. You only get this problem if you swap from XRP to Firo?

davincci9412 commented 2 years ago

Have you tested Swap from XRP to Firo in "ChangeNow"? no "Destination Tag" - would you plz attach your screenshots?

sirrok commented 2 years ago

Hi davincci9412, So, if I want to make a swap from "Firo" to "XRP" from the Firo client, and this swap should be as destination for example Binance, then "must" specify a "Destination Tag", otherwise the coins (XRP) are lost in this case. There is no possibility to enter the "Destination Tag" in both "ChangeNow" and "StealthEx". I send you here for both a screenshots. The field "Destination Tag" does not exist in the Firo Client !

changenow_swap-to-xrp

stealthEx_swap-to-xrp

sirrok commented 2 years ago

Hello I have answered you via Github !

Von: Davincci @.*** Gesendet: Mittwoch, 20. Juli 2022 12:05 An: firoorg/firo-client Cc: sirrok; Author Betreff: Re: [firoorg/firo-client] Swap from XRP to Firo -> NO Destination Tag (Issue #179)

Have you tested Swap from XRP to Firo in "ChangeNow"? no "Destination Tag" - would you plz attach your screenshots?

— Reply to this email directly, view it on GitHub https://github.com/firoorg/firo-client/issues/179#issuecomment-1190081905 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AJBT3VHECR2RMRPAYHHJ253VU 7FMNANCNFSM5YGZ6MEA . You are receiving this because you authored the thread. https://github.com/notifications/beacon/AJBT3VCXCIP2GV6Q2PE2AM3VU7FMNA5CNFS M5YGZ6MEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOI3XTK4I .gif Message ID: @.***>