Closed ghost closed 1 year ago
This pull request fixes 4 alerts when merging cf2b38bfdf80f2f91f8c6ed3749f1ef240f040c5 into 1e9bad81f3dd3420e4ad081cceaefd3f2ca8497e - view on LGTM.com
fixed alerts:
This pull request fixes 2 alerts when merging 3546005732adab81a1c16ae28b7f89d4fa0ab246 into 1e9bad81f3dd3420e4ad081cceaefd3f2ca8497e - view on LGTM.com
fixed alerts:
This pull request introduces 2 alerts when merging 40ce1d20232d8928486e7b3a963f18d722952b1f into bd9190d56bc7362c3cce74550a6a9090dd0400a3 - view on LGTM.com
new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine :gear: that powers LGTM.com. For more information, please check out our post on the GitHub blog.
PR intention
This fixes several instances of UB.
Code changes brief
CQuorumBlockProcessor::GetCommitmentsFromBlock
- std::move() was used incorrectly, leading to a use after free issue.CDKGSessionHandler::SleepBeforePhase
- An invalid implicit cast fromUINT64_MAX
todouble
is performed in some cases.